-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add response check after trying to download script. #379
Merged
msftcoderdjw
merged 5 commits into
eclipse-symphony:main
from
lirenjie95:bugFix/CheckRespStatus
Aug 14, 2024
Merged
Add response check after trying to download script. #379
msftcoderdjw
merged 5 commits into
eclipse-symphony:main
from
lirenjie95:bugFix/CheckRespStatus
Aug 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lirenjie95
commented
Jul 31, 2024
- create local script file after checking the response
- if the response is not 200, don't write it to local file (to avoid writing "404 Not Found")
lirenjie95
force-pushed
the
bugFix/CheckRespStatus
branch
from
July 31, 2024 12:31
91f8af6
to
0d8421e
Compare
RemindD
reviewed
Aug 2, 2024
lirenjie95
force-pushed
the
bugFix/CheckRespStatus
branch
from
August 2, 2024 08:04
86593df
to
b44b2db
Compare
iwangjintian
reviewed
Aug 2, 2024
LeiQL
reviewed
Aug 5, 2024
lirenjie95
force-pushed
the
bugFix/CheckRespStatus
branch
from
August 7, 2024 08:54
7f18fa5
to
2956501
Compare
RemindD
approved these changes
Aug 13, 2024
msftcoderdjw
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.