Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webhook for activation in case campaign doesn't exist #302

Merged
merged 10 commits into from
Jun 17, 2024
Merged

Add webhook for activation in case campaign doesn't exist #302

merged 10 commits into from
Jun 17, 2024

Conversation

RemindD
Copy link
Contributor

@RemindD RemindD commented Jun 10, 2024 •
edited
Loading

@RemindD RemindD changed the title Fix null ref in stage-vendor and Redis configuration Fix null ref in stage-vendor and set proper Redis configuration Jun 10, 2024
@RemindD RemindD force-pushed the users/xingdong/redisConfig branch from aa59063 to 2e5d2d0 Compare June 11, 2024 04:19
Haishi2016
Haishi2016 previously approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@Haishi2016 Haishi2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine but eventually we want to block creating activation without a campaign

@RemindD
Copy link
Contributor Author

RemindD commented Jun 11, 2024 •
edited
Loading

@msftcoderdjw @Haishi2016 I have added webhook for activation to check if campaign exists or not. The error message would be like:
The Activation "04workflow" is invalid: spec.campaign: Invalid value: "04campaign:v1": campaign doesn't exist
And I will still keep the changes in the API side for 1). standalone mode 2). campaign could be deleted after the activation passes webhook check.
Could you please kindly review?

@RemindD RemindD marked this pull request as draft June 11, 2024 13:54
@RemindD RemindD force-pushed the users/xingdong/redisConfig branch from 48a73a8 to c67236a Compare June 11, 2024 14:48
@RemindD RemindD changed the title Fix null ref in stage-vendor and set proper Redis configuration Add webhook for activation in case campaign doesn't exist Jun 11, 2024
@RemindD RemindD marked this pull request as ready for review June 11, 2024 14:51
@RemindD RemindD force-pushed the users/xingdong/redisConfig branch from c67236a to 557341b Compare June 11, 2024 14:56
msftcoderdjw
msftcoderdjw previously approved these changes Jun 11, 2024
View reviewed changes
@RemindD RemindD marked this pull request as draft June 12, 2024 00:44
Haishi2016
Haishi2016 previously approved these changes Jun 12, 2024
View reviewed changes
@RemindD RemindD dismissed stale reviews from Haishi2016 and msftcoderdjw via 27eee25 June 12, 2024 13:38
@RemindD RemindD force-pushed the users/xingdong/redisConfig branch from 54ca95b to 27eee25 Compare June 12, 2024 13:38
@RemindD RemindD marked this pull request as ready for review June 12, 2024 14:21
@msftcoderdjw msftcoderdjw merged commit fc6abcf into eclipse-symphony:main Jun 17, 2024
5 checks passed
@msftcoderdjw msftcoderdjw deleted the users/xingdong/redisConfig branch June 17, 2024 05:19
@lirenjie95 lirenjie95 mentioned this pull request Jul 15, 2024
Closed
@msftcoderdjw msftcoderdjw mentioned this pull request Aug 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeiQL LeiQL LeiQL left review comments

@msftcoderdjw msftcoderdjw msftcoderdjw approved these changes

@Haishi2016 Haishi2016 Haishi2016 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Symphony API unexpected crash when campaign doesn't exist for activation
4 participants
@RemindD @Haishi2016 @LeiQL @msftcoderdjw