Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs and change fields #289

Merged
merged 8 commits into from
Jun 6, 2024
Merged

Fix docs and change fields #289

merged 8 commits into from
Jun 6, 2024

Conversation

FireDefend
Copy link
Contributor

  1. change "type" field of catalog to "catalogType".
  2. delete "arguments" of Instances.
  3. fix some docs

@Haishi2016
Copy link
Contributor

Why changing Type to CatalogType as it's already under the Catalog type?

@msftcoderdjw
Copy link
Contributor

@FireDefend please rebase with latest main.

@msftcoderdjw
Copy link
Contributor

Why changing Type to CatalogType as it's already under the Catalog type?

ARM doesn't allow there is type field in ARM resource properties. We have to change it with catalogType. This PR is to align with ARM spec. @FireDefend

@FireDefend
Copy link
Contributor Author

@FireDefend please rebase with latest main.

rebased and fixed tests

@Haishi2016 Haishi2016 merged commit 5f61376 into eclipse-symphony:main Jun 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msftcoderdjw msftcoderdjw msftcoderdjw approved these changes

@Haishi2016 Haishi2016 Awaiting requested review from Haishi2016 Haishi2016 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FireDefend @Haishi2016 @msftcoderdjw