Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize image build and integration test #270

Merged
merged 11 commits into from
May 22, 2024

Conversation

msftcoderdjw
Copy link
Contributor

Changes:

  1. Based on the review requirements, we need to use different base images to generate Symphony-api and Symphony-k8s for Azure builds. So include base image ARG in dockerfile and provider override mage utility functions.
  2. Provide ways to customize integration tests.
  3. Fix typos and unused imagePrivateRegistryUrl.

@msftcoderdjw msftcoderdjw requested a review from Haishi2016 as a code owner May 20, 2024 10:15
Copy link
Contributor

@Haishi2016 Haishi2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we produce a non-Microsoft release now? We need to keep in mind that this is still an OSS repo that is supposed to remain Microsoft neutral.

@msftcoderdjw
Copy link
Contributor Author

msftcoderdjw commented May 21, 2024

How do we produce a non-Microsoft release now? We need to keep in mind that this is still an OSS repo that is supposed to remain Microsoft neutral.

For non-Microsoft release, we still rely on https://github.com/eclipse-symphony/symphony/actions/workflows/release.yaml to generate build. Yes, we are trying to keep OSS repo Microsoft neutral so we add arguments to Dockerfile instead of just check in the base images. We will override the required base images in downstream projects build.

@msftcoderdjw msftcoderdjw merged commit 034b25f into eclipse-symphony:main May 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants