Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle type conversion errors #258

Merged
merged 2 commits into from
May 16, 2024
Merged

Handle type conversion errors #258

merged 2 commits into from
May 16, 2024

Conversation

RemindD
Copy link
Contributor

@RemindD RemindD commented May 14, 2024

Fix #257

@RemindD RemindD force-pushed the users/xingdong/type branch from 9c6d03e to a9e21a5 Compare May 14, 2024 05:40
msftcoderdjw
msftcoderdjw reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@msftcoderdjw msftcoderdjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title seems to be stage providers.

@RemindD RemindD changed the title Handle type conversion error in state providers Handle type conversion error in stage providers May 14, 2024
msftcoderdjw
msftcoderdjw requested changes May 14, 2024
View reviewed changes
Copy link
Contributor

@msftcoderdjw msftcoderdjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please help to go through the whole codebase. I found we have similar issues in reference manager. Please try to fix as much as possible.

@RemindD RemindD changed the title Handle type conversion error in stage providers Handle type conversion errors May 14, 2024
@msftcoderdjw msftcoderdjw merged commit 8a839b9 into eclipse-symphony:main May 16, 2024
5 checks passed
@RemindD RemindD deleted the users/xingdong/type branch September 13, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msftcoderdjw msftcoderdjw msftcoderdjw approved these changes

@Haishi2016 Haishi2016 Haishi2016 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle type conversion error in state providers
3 participants
@RemindD @Haishi2016 @msftcoderdjw