remove all username pwd calls. (only keep for child and parent communication) #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haishi2016
reviewed
May 9, 2024
RemindD
reviewed
May 13, 2024
Haishi2016
reviewed
May 13, 2024
iwangjintian
force-pushed
the
users/jesse/endpoint
branch
from
b8b7919 to
0b9391e
Compare
msftcoderdjw
requested changes
May 15, 2024
msftcoderdjw
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the api to api calls are now using TLS + SAT. We do this by initializing an overall apiclient with the symphony api address set in the pod env parameter.
We keep the http + user creds for child and parent communications since TLS + SAT by default doesn't work. The reason why we don't use an overall apiclient for parent calls is that parent urls may change. (Thought it doesn't work like this now) That's why we think singleton doesn't apply to parent-children apiclient.
Definitely some corresponding tests changes. I manually tested the multisite scenario.