-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new CRDs to support root resource mapping #250
Add new CRDs to support root resource mapping #250
Conversation
Just to double-check, the plan is to add these CRDs first and then do renaming later? |
@Haishi2016 renaming is not scheduled before private preview. We can add a task for renaming and schedule it based on priorities. And FYI, the support of object reference (myapp:latest, myapp:v1-0) is under development and testing. I will have PRs for the support of labelling and reference. |
packages/helm/symphony/templates/symphony-core/symphonyk8s.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR introduces the first part of versioning changes - modify data model. I am OK with this change. Team can review and drop more comments if needed. One more suggestion is maybe we don't need to keep rootResource and version in Spec. It is better to keep them in metadata like metadata.name.
|
@Haishi2016 @msftcoderdjw do we have any other concerns or questions on this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this PR, with understanding that 1) we are going to refactor the version and rootresource attributes out of spec in the future; 2) we need to bring similar changes to other object types like devices, skills and models; 3) we are going to do renaming of objects in upcoming PRs.
rootResource
andversion
in solution, target, instance, catalog, campaign to support liquid property mapping