Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new CRDs to support root resource mapping #250

Merged
merged 6 commits into from
May 17, 2024

Conversation

LeiQL
Copy link
Contributor

@LeiQL LeiQL commented May 8, 2024

  • Add new CRDs: instanceContainer, solutionContainer, targetContainer, catalogContainer, campaignContainer
  • Add rootResource and version in solution, target, instance, catalog, campaign to support liquid property mapping

@Haishi2016
Copy link
Contributor

Just to double-check, the plan is to add these CRDs first and then do renaming later?

@LeiQL
Copy link
Contributor Author

LeiQL commented May 9, 2024

t to double-check, the plan is to add these CRDs first and then do renaming

@Haishi2016 renaming is not scheduled before private preview. We can add a task for renaming and schedule it based on priorities. And FYI, the support of object reference (myapp:latest, myapp:v1-0) is under development and testing. I will have PRs for the support of labelling and reference.

Copy link
Contributor

@msftcoderdjw msftcoderdjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR introduces the first part of versioning changes - modify data model. I am OK with this change. Team can review and drop more comments if needed. One more suggestion is maybe we don't need to keep rootResource and version in Spec. It is better to keep them in metadata like metadata.name.

@LeiQL
Copy link
Contributor Author

LeiQL commented May 15, 2024

This PR introduces the first part of versioning changes - modify data model. I am OK with this change. Team can review and drop more comments if needed. One more suggestion is maybe we don't need to keep rootResource and version in Spec. It is better to keep them in metadata like metadata.name.

metadata field liquid mapping only mentions metdata.name mapping. It needs to be investigated whether other fields in metadata can be mapped via liquid. This can be scheduled post private preview.

@LeiQL LeiQL closed this May 15, 2024
@LeiQL LeiQL reopened this May 15, 2024
@LeiQL
Copy link
Contributor Author

LeiQL commented May 16, 2024

@Haishi2016 @msftcoderdjw do we have any other concerns or questions on this PR?

Copy link
Contributor

@Haishi2016 Haishi2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this PR, with understanding that 1) we are going to refactor the version and rootresource attributes out of spec in the future; 2) we need to bring similar changes to other object types like devices, skills and models; 3) we are going to do renaming of objects in upcoming PRs.

@msftcoderdjw msftcoderdjw merged commit e542cc6 into eclipse-symphony:main May 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants