fix(deps): Deprecate old commmons-lang library #2750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heliocastro
requested review from
GMishx,
KoukiHama,
arunazhakesan and
ag4ums
as code owners
heliocastro
added
ready
heliocastro
force-pushed
the
fix/deprecate_old_commons
branch
from
0710bad to
cd9201c
Compare
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
heliocastro
force-pushed
the
fix/deprecate_old_commons
branch
from
cd9201c to
9f3c99c
Compare
|
@heliocastro This PR was changed from We have discussed the same multiple times as a bad practice. |
|
Total my fault. I was in transit with plenty of tabs and was merging one
after another.
Sorry for that, I verified again to check if was harmful but is fine.
Promise will not happens again, and I will try put operation from frontend
and backend more separated.
…On Fri, Dec 20, 2024, 04:19 Gaurav Mishra ***@***.***> wrote:
@heliocastro <https://github.com/heliocastro> This PR was changed from WIP
(thus not reviewed) to ready and self-merged without any review from
anyone other than yourself. This does not follow the guidelines set for the
SW360 project:
https://eclipse.dev/sw360/docs/development/dev-dod-and-style/
We have discussed the same multiple times as a bad practice.
—
Reply to this email directly, view it on GitHub
<#2750 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADGDAEAXPCJDECN7FD2AAL2GPAIDAVCNFSM6AAAAABSPY2FMSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJWGQZDMNJVGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old apache-commons-lang was puled down by nouveau-handler, and misleading outdated code in different sources.
All code now is adjusted to commons-lang3 or commons-text where needed.