Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 19.0.0-SNAPSHOT version #2659

Closed
wants to merge 1 commit into from

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Oct 30, 2024

Please provide a summary of your changes here.

First version tag after 19.0.0 release.

Suggest Reviewer

@heliocastro @KoukiHama @ag4ums @arunazhakesan

How To Test?

Build and install SW360.

Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
@GMishx GMishx force-pushed the chore/rel/19.0-SNAPSHOT branch from 4e9eac3 to 66cba49 Compare October 30, 2024 09:34
Copy link
Contributor

@heliocastro heliocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use SNAPSHOT or 19.99.x ?

@GMishx
Copy link
Member Author

GMishx commented Nov 4, 2024

19.99.x will not be helpful if we want to follow semantic versioning.

I created this SNAPSHOT branch following previous releases. I am not sure about Maven versioning scheme yet. What would be the best way to do this?

@GMishx
Copy link
Member Author

GMishx commented Nov 5, 2024

I read about Maven versioning and understood SNAPSHOT versions force maven to pull latest artifact from maven repository. Since we are not publishing anything there, we can skip the SNAPSHOT version and just follow the semantic versioning.

@heliocastro
Copy link
Contributor

@GMishx Maybe close this PR and push 19.0.1 instead ?
You can use this:

mvn versions:set -DnewVersion=19.0.1

@GMishx
Copy link
Member Author

GMishx commented Nov 6, 2024

Closing the PR as proposed. Will update the release document and open new PR for 19.0.1

@GMishx GMishx closed this Nov 6, 2024
@GMishx GMishx deleted the chore/rel/19.0-SNAPSHOT branch November 6, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants