-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify backend source code #2609
base: main
Are you sure you want to change the base?
Conversation
Thank you for big works. I will review it. |
f5585d0
to
8fbc0d1
Compare
4ad4834
to
69bc3e0
Compare
@KoukiHama @GMishx Can we go ahead on this, we already have one conflict and will be only get worse ahead |
@heliocastro The changes looks good to me and I just tested the branch and the {
"timestamp": "2024-09-20T05:54:24.790291950Z",
"status": 500,
"error": "Internal Server Error",
"message": "HTTP Response code: 404"
} Other than this break, I approve the PR. Also, please understand we need to move carefully (definitely not mean slowly) for such major changes. More so, when the build time is down from 120 seconds to 45 seconds 😉 I do understand your pain with constant conflict resolution, but please also understand this PR will cause merge conflict for 50 other PRs at the same time. |
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
- Update parent backend pom to proper naming jar files sw360 prefixed Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
…rocess Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
…n server Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
69bc3e0
to
58bd546
Compare
Yes, but will always have PRs, so if we go in this mode, we will never do the changes. I just rebased again with CycloneDX, and this will go forever, so we need merge it, and fix the PR, but not wit the PR's because wealways come some more, and more |
I agree to the point, that's why I approved it. However, we cannot merge a PR which breaks existing functionality, that too as basic as Once the components endpoint is fixed, I am good with merging this PR. I guess @KoukiHama wanted to review it as well. |
I'm currently in the process of reviewing. I've gone through about half of it and will finish reviewing everything by the weekend. |
I agree with this approach as well. While it's important to make progress, we shouldn't merge the PR until the basic functionality is fixed. Once the error is resolved, we can proceed with the merge. |
Reference: #2602