fix(rest): modified accept request to see the proposed changes in user to moderation request rest Api. #2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMishx
added
needs code review
needs general test
GMishx
requested changes
Jul 30, 2024
...a/org/eclipse/sw360/rest/resourceserver/moderationrequest/Sw360ModerationRequestService.java
Outdated
Show resolved
Hide resolved
...a/org/eclipse/sw360/rest/resourceserver/moderationrequest/Sw360ModerationRequestService.java
Outdated
Show resolved
Hide resolved
nikkuma7
force-pushed
the
fix/db-update-on-moderation-accept-for-user
branch
from
e3d48e1
to
6ea1408
Compare
|
@amritkv can you please test this PR? |
… request. Signed-off-by: Nikesh kumar <kumar.nikesh@simens.com>
GMishx
force-pushed
the
fix/db-update-on-moderation-accept-for-user
branch
from
6ea1408
to
5943127
Compare
|
The branch is now rebased with latest main @amritkv , please check again. |
GMishx
added
ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2490, #2518
###Description
Upon clicking the "Accept Request" button for a moderation request, the REST API response returns a 202 (Accepted) status. However, the database is not being updated with the proposed changes. For example, if a project page is edited and a moderation request is created, accepting the proposed changes does not update the project page with the new values; it still shows the old values.
Issue:
Suggest Reviewer
How To Test?
Checklist
Must: