-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ComponentPortlet & ImportCDX): Validate VCS URL #2408
feat(ComponentPortlet & ImportCDX): Validate VCS URL #2408
Conversation
7810ffa
to
5265dc0
Compare
Hi @afsahsyeda |
5265dc0
to
413cb7e
Compare
@@ -858,7 +858,7 @@ link.to.project=Link to Project | |||
link.to.projects=Link to Projects | |||
list.of.components.without.version.information=List of Components without version information | |||
list.of.invalid.packages.without.purl.or.name.or.version=List of invalid Packages without purl or name or version | |||
list.of.packages.without.vcs.information=List of Packages without VCS information | |||
list.of.packages.without.vcs.information=List of Packages with invalid or missing VCS information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a workaround until we migrate to React framework. Did not want to touch the jsp files involving liferay variables.
413cb7e
to
7af7600
Compare
Testing this PR |
@akapti @afsahsyeda @akshitjoshii vcs field is not getting updated via rest api |
7af7600
to
c1480f2
Compare
c1480f2
to
c9f2770
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good.
@afsahsyeda please rebase the branch with latest main without the frontend changes. |
…Hub Repo URLs during CDX import Signed-off-by: afsahsyeda <afsah.syeda@siemens-healthineers.com>
c9f2770
to
771b965
Compare
@GMishx Please code review the PR again as I have made a few additional changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good.
Description:
Closes #2377
How To Test?
Relevant Screenshots: