-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rest): saveUsages in project page #2372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudra-superrr
force-pushed
the
feat/saveUsages
branch
from
March 21, 2024 06:30
01359d1
to
6013005
Compare
rudra-superrr
added
needs code review
needs general test
This is general testing, meaning that there is no org specific issue to check for
REST
labels
Mar 21, 2024
rudra-superrr
force-pushed
the
feat/saveUsages
branch
from
March 21, 2024 06:52
6013005
to
e915922
Compare
heliocastro
added
the
New-UI
Level for the API and UI level changes for the new-ui
label
Mar 27, 2024
rudra-superrr
force-pushed
the
feat/saveUsages
branch
2 times, most recently
from
April 23, 2024 08:19
648c302
to
822dc33
Compare
rudra-superrr
force-pushed
the
feat/saveUsages
branch
from
April 24, 2024 09:34
822dc33
to
360ce67
Compare
Testing this PR. |
GMishx
previously approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good. Please rebase with latest main.
rudra-superrr
force-pushed
the
feat/saveUsages
branch
2 times, most recently
from
August 19, 2024 06:24
b93a070
to
86950a6
Compare
@keerthi-bl please retest the branch after rebase. |
rudra-superrr
force-pushed
the
feat/saveUsages
branch
from
September 2, 2024 07:37
86950a6
to
a961a94
Compare
Rebase completed, now you can retest this @keerthi-bl . |
Signed-off-by: Rudra Chopra <prabhuchopra@gmail.com>
rudra-superrr
force-pushed
the
feat/saveUsages
branch
from
September 2, 2024 07:53
a961a94
to
49e5855
Compare
GMishx
added
ready
ready to merge
and removed
needs general test
This is general testing, meaning that there is no org specific issue to check for
labels
Oct 21, 2024
GMishx
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Closes #2371
Description: this new endpoint is used to save attachmnetUsages for the project.
How to test:
Pass Map< String, List< String >> in request body.
String can be of 4 types:
Format of String inside list varies according to the usageFields (sourcePackage, licenseInfo, manuallySet) :
sourcePackage
, releaseId_sourcePakage_attachmentContentIdlicenseInfo
, projectId-releaseId_licenseInfo_attachmentContentId (for directly linked project) OR projectPath-releaseId_licenseInfo_attachmentContentId (for nested projects)manuallySet
, releaseId_manuallySet_attachmentContentIdExample:
{"selected": ["4427a8e723ad405db63f75170ef240a2_sourcePackage_5c5d6f54ac6a4b33bcd3c5d3a8fefc43", "value2"],
"deselected": ["de213309ba0842ac8a7251bf27ea8f36_manuallySet_eec66c3465f64f0292dfc2564215c681", "value2"],
"selectedConcludedUsages": ["de213309ba0842ac8a7251bf27ea8f36_licenseInfo_eec66c3465f64f0292dfc2564215c681"],"
"deselectedConcludedUsages":
["ade213309ba0842ac8a7251bf27ea8f36_licenseInfo_aeec66c3465f64f0292dfc2564215c681"]}