Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rest): create new enpoint to upload component csv file. #2308

Merged
merged 1 commit into from
Jan 6, 2025
Merged

feat(rest): create new enpoint to upload component csv file. #2308

merged 1 commit into from
Jan 6, 2025

Conversation

nikkuma7
Copy link
Contributor

@nikkuma7 nikkuma7 commented Feb 12, 2024 •
edited by GMishx
Loading

Please provide a summary of your changes here.

  • Which issue is this pull request belonging to and how is it solving it? (Refer to issue here)
  • Did you add or update any new dependencies that are required for your change?

Closes #2307

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

1: Login with admin access
2: Go to admin tab and check in ImportExport subtab.
3: upload componetFile/releaseFile/componentAttachment file and file type will be .csv

URL: http://localhost:8080/resource/api/importExport/componentAttachment
URL: http://localhost:8080/resource/api/importExport/uploadRelease
URL: http://localhost:8080/resource/api/importExport/uploadComponent

How should these changes be tested by the reviewer?
Have you implemented any additional tests?

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@nikkuma7 nikkuma7 force-pushed the feat/uploadComponentFile branch from 72b21fd to c7b3480 Compare February 13, 2024 07:49
@ag4ums ag4ums added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for has merge conflicts labels Mar 15, 2024
@nikkuma7 nikkuma7 force-pushed the feat/uploadComponentFile branch from c7b3480 to 907be4f Compare March 26, 2024 07:44
@heliocastro heliocastro added the New-UI Level for the API and UI level changes for the new-ui label Mar 27, 2024
@eldrin30 eldrin30 self-assigned this May 7, 2024
@nikkuma7 nikkuma7 force-pushed the feat/uploadComponentFile branch from 907be4f to 159a984 Compare May 16, 2024 09:37
@GMishx
Copy link
Member

GMishx commented Sep 6, 2024

@nikkuma7 please rebase with latest main

@nikkuma7 nikkuma7 force-pushed the feat/uploadComponentFile branch from 159a984 to 1addd63 Compare September 10, 2024 05:18
@nikkuma7
Copy link
Contributor Author

Done. Rebase with latest main.

@nikkuma7 nikkuma7 force-pushed the feat/uploadComponentFile branch from 1addd63 to 7df0f94 Compare September 10, 2024 07:47
GMishx
GMishx requested changes Oct 17, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change needed.

...c/main/java/org/eclipse/sw360/rest/resourceserver/importexport/Sw360ImportExportService.java Outdated Show resolved Hide resolved
...c/main/java/org/eclipse/sw360/rest/resourceserver/importexport/Sw360ImportExportService.java Outdated Show resolved Hide resolved
@nikkuma7 nikkuma7 force-pushed the feat/uploadComponentFile branch from 7df0f94 to 76bef86 Compare October 18, 2024 06:06
GMishx
GMishx previously approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Please rebase once @nikkuma7

@GMishx
Copy link
Member

GMishx commented Oct 21, 2024

@rudra-superrr please help with testing this PR.

@nikkuma7 nikkuma7 force-pushed the feat/uploadComponentFile branch from 76bef86 to ae9010e Compare October 22, 2024 08:00
@rudra-superrr
Copy link
Contributor

Rest docs are broken.
image

@nikkuma7 nikkuma7 force-pushed the feat/uploadComponentFile branch from ae9010e to 57cf12e Compare November 3, 2024 09:06
@nikkuma7
Copy link
Contributor Author

nikkuma7 commented Nov 3, 2024

Rest docs are broken. image

done.

@rudra-superrr
Copy link
Contributor

Docs are still broken.

@nikkuma7 nikkuma7 force-pushed the feat/uploadComponentFile branch from 57cf12e to 1f7675b Compare November 27, 2024 05:27
@GMishx GMishx added this to the Release - 20.0.0 milestone Nov 27, 2024
GMishx
GMishx requested changes Dec 4, 2024
View reviewed changes
...src/main/java/org/eclipse/sw360/rest/resourceserver/importexport/ImportExportController.java Outdated Show resolved Hide resolved
...src/main/java/org/eclipse/sw360/rest/resourceserver/importexport/ImportExportController.java Outdated Show resolved Hide resolved
...src/main/java/org/eclipse/sw360/rest/resourceserver/importexport/ImportExportController.java Outdated Show resolved Hide resolved
...src/main/java/org/eclipse/sw360/rest/resourceserver/importexport/ImportExportController.java Outdated Show resolved Hide resolved
...src/main/java/org/eclipse/sw360/rest/resourceserver/importexport/ImportExportController.java Outdated Show resolved Hide resolved
...src/main/java/org/eclipse/sw360/rest/resourceserver/importexport/ImportExportController.java Outdated Show resolved Hide resolved
...src/main/java/org/eclipse/sw360/rest/resourceserver/importexport/ImportExportController.java Outdated Show resolved Hide resolved
...src/main/java/org/eclipse/sw360/rest/resourceserver/importexport/ImportExportController.java Outdated Show resolved Hide resolved
...c/main/java/org/eclipse/sw360/rest/resourceserver/importexport/Sw360ImportExportService.java Outdated Show resolved Hide resolved
@GMishx GMishx assigned nikkuma7 and unassigned rudra-superrr and eldrin30 Dec 4, 2024
@nikkuma7
feat(rest): create new enpoint to upload component csv file.
eccd220 
Signed-off-by: Nikesh kumar <kumar.nikesh@siemens.com>
@nikkuma7 nikkuma7 force-pushed the feat/uploadComponentFile branch from 1f7675b to eccd220 Compare January 6, 2025 08:25
@nikkuma7
Copy link
Contributor Author

nikkuma7 commented Jan 6, 2025

@GMishx Comment Addressed.

GMishx
GMishx approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@GMishx GMishx added ready ready to merge and removed needs general test This is general testing, meaning that there is no org specific issue to check for labels Jan 6, 2025
@GMishx GMishx merged commit be7606f into eclipse-sw360:main Jan 6, 2025
3 checks passed
@GMishx GMishx deleted the feat/uploadComponentFile branch January 6, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMishx GMishx GMishx approved these changes

@heliocastro heliocastro Awaiting requested review from heliocastro heliocastro is a code owner

@KoukiHama KoukiHama Awaiting requested review from KoukiHama KoukiHama is a code owner

@arunazhakesan arunazhakesan Awaiting requested review from arunazhakesan arunazhakesan is a code owner

@ag4ums ag4ums Awaiting requested review from ag4ums ag4ums is a code owner

Assignees

@nikkuma7 nikkuma7

Labels
New-UI Level for the API and UI level changes for the new-ui ready ready to merge
Projects
None yet
Milestone
Release - 20.0.0
Development

Successfully merging this pull request may close these issues.

feat(rest): create new enpoint to upload component csv file.
6 participants
@nikkuma7 @GMishx @rudra-superrr @heliocastro @ag4ums @eldrin30