Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rel): changing files for tagging 14.0 #1417

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

ag4ums
Copy link
Contributor

@ag4ums ag4ums commented Nov 24, 2021

Please provide a summary of your changes here.

This PR is change log for release 14.0.0

Issue:

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

How should these changes be tested by the reviewer?
Have you implemented any additional tests?

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

Copy link
Contributor

@JaideepPalit JaideepPalit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the PR.
Kindly have a look at some minor review comments

CHANGELOG.md Outdated
@@ -4,6 +4,87 @@ This is the changelog file of the sw360 project. It starts with the first releas

https://github.com/sw360/sw360portal/releases

## sw360-14.0.0-M1

This tag covers many corrections/bug fixes after the 13.3 release.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess last version should be 13.4, same for line 11

pom.xml Outdated
@@ -50,7 +50,7 @@
<!-- This is first of two places for changing the version of SW360 -->
<!-- note that 6.1.0-SNAPSHOT relates to 6.0.${patchlevel} -->
<!-- pls see also the profile cli -->
<revision>13.4.${patchlevel}</revision>
<revision>14.0.${patchlevel}</revision>
<patchlevel>0-SNAPSHOT</patchlevel>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess SNAPSHOT should be removed while creating a relaese.
And then added back after release is done?

CHANGELOG.md Outdated

### Migrations

For this version, no database migration is necessary.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a migration script for

  • e3d8122a feat(ProjectUI): Add new values to Obligation status

Copy link
Contributor

@JaideepPalit JaideepPalit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good after changes

@JaideepPalit JaideepPalit merged commit 63a1fa6 into eclipse-sw360:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants