-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flowchart library #423
Flowchart library #423
Conversation
Signed-off-by: Guillaume Fontorbe <guillaume.fontorbe@typefox.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Remark about the previously merged #416: I think examples/flowchart/src/model-source.ts is not necessary. You can simply pass the model in to the updateModel
call in standalone.ts.
Signed-off-by: Guillaume Fontorbe <guillaume.fontorbe@typefox.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, just one improvement:
Signed-off-by: Guillaume Fontorbe <guillaume.fontorbe@typefox.io>
Added a more specific model element for each element in the container. We can replace that when we have a free form anchor computation in place |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Adds a new package
sprotty-library
which serves as a collection of views with the aim of making easier to start a diagramming solution based on widely used diagrams.The first part of the new package implements views and interfaces for dealing with flowchart diagrams.
It also provides an inversify
ContainerModule
where node and edges types are link to the provided views.