Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider compartments in ELK layout, add pre/postprocessors #362

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Consider compartments in ELK layout, add pre/postprocessors #362

merged 1 commit into from
Jun 28, 2023

Conversation

spoenemann
Copy link
Contributor

Closes #259.

Also improves extensibility of the ElkLayoutEngine:

  • Split transformToElk into multiple methods and deprecated the old one
  • Added optional ILayoutPreprocessor and ILayoutPostprocessor services

@spoenemann spoenemann added this to the v0.14.0 milestone May 31, 2023
@spoenemann
Copy link
Contributor Author

@planger @tortmayr @dhuebner any objections to merging this?

dhuebner
dhuebner approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@dhuebner dhuebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea to split the implementation into multiple methods!

planger
planger approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, no objections at all! 👍

@spoenemann spoenemann merged commit 995e1a3 into master Jun 28, 2023
@spoenemann spoenemann deleted the spoenemann/elk-layout-support-compartments-259 branch June 28, 2023 15:50
@Rtulpe Rtulpe mentioned this pull request Oct 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@planger planger planger approved these changes

@dhuebner dhuebner dhuebner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.

ELK layout: Support compartments
3 participants
@spoenemann @dhuebner @planger