Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[896] Add default implementation of the new methods to the interface #910

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

pcdavid
Copy link
Member

@pcdavid pcdavid commented Dec 27, 2021

This avoids breaking the API for existing clients.

Bug: #896
Signed-off-by: Pierre-Charles David pierre-charles.david@obeo.fr

Type of this PR

  • Bug fix
  • New feature or improvement
  • Documentation
  • Cleanup
  • Test
  • Build/Releng

Issue(s)

...

What does this PR do?

...

Screenshot/screencast of this PR

...

Potential side effects

...

How to test this PR?

  • Frontend Unit tests
  • Backend Unit tests
  • Cypress : please specify
  • Manual Test : please specify

Checklist

  • I have read CONTRIBUTING carefully.
  • I have signed the Contributor License Agreement.
  • All my commits are signed-off (-s) with my mail address of my Eclipse Account.
  • I have covered my changes by unit tests or integration tests or manual tests.
  • All tests pass.
  • I have updated the documentation accordingly
  • New React components are availables in storybook

This avoids breaking the API for existing clients.

Bug: #896
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@sbegaudeau sbegaudeau added this to the 2022.01.0 milestone Jan 4, 2022
@sbegaudeau sbegaudeau linked an issue Jan 4, 2022 that may be closed by this pull request
1 task
@sbegaudeau sbegaudeau merged commit 49636b3 into master Jan 4, 2022
@sbegaudeau sbegaudeau deleted the pcd/clean/default-layout-methods branch January 4, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to make specific changes before and after the layout
2 participants