-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3392] Prevents edge from passing through another node #3393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frouene
force-pushed
the
fro/enh/smart-edges
branch
3 times, most recently
from
April 16, 2024 15:07
90b9b2c
to
e283860
Compare
pcdavid
reviewed
Apr 16, 2024
packages/diagrams/frontend/sirius-components-diagrams/src/renderer/layout/layoutNode.ts
Outdated
Show resolved
Hide resolved
packages/diagrams/frontend/sirius-components-diagrams/src/renderer/layout/layoutNode.ts
Outdated
Show resolved
Hide resolved
packages/diagrams/frontend/sirius-components-diagrams/src/renderer/layout/layoutNode.ts
Outdated
Show resolved
Hide resolved
packages/diagrams/frontend/sirius-components-diagrams/src/renderer/layout/layoutNode.ts
Show resolved
Hide resolved
frouene
force-pushed
the
fro/enh/smart-edges
branch
4 times, most recently
from
April 18, 2024 14:03
01ef457
to
dc53839
Compare
mcharfadi
requested changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/diagrams/frontend/sirius-components-diagrams/src/renderer/edge/CommonEdge.tsx
Outdated
Show resolved
Hide resolved
packages/diagrams/frontend/sirius-components-diagrams/src/renderer/edge/CommonEdge.types.ts
Outdated
Show resolved
Hide resolved
packages/diagrams/frontend/sirius-components-diagrams/src/renderer/edge/EdgeLayout.ts
Show resolved
Hide resolved
mcharfadi
reviewed
Apr 23, 2024
packages/diagrams/frontend/sirius-components-diagrams/src/renderer/edge/MultiLabelEdge.tsx
Outdated
Show resolved
Hide resolved
frouene
force-pushed
the
fro/enh/smart-edges
branch
2 times, most recently
from
April 29, 2024 09:24
f2ab3f2
to
f429dd2
Compare
mcharfadi
approved these changes
Apr 29, 2024
frouene
force-pushed
the
fro/enh/smart-edges
branch
from
April 30, 2024 09:35
f429dd2
to
9a6bc51
Compare
Bug: #3392 Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
mcharfadi
force-pushed
the
fro/enh/smart-edges
branch
from
April 30, 2024 09:56
9a6bc51
to
f5bcc45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: #3392
Pull request template
General purpose
What is the main goal of this pull request?
Project management
priority:
andpr:
labels been added to the pull request? (In case of doubt, start with the labelspriority: low
andpr: to review later
)area:
,difficulty:
,type:
)CHANGELOG.adoc
been updated to reference the relevant issues?CHANGELOG.adoc
? (Including changes in the GraphQL API)CHANGELOG.adoc
? For example indoc/screenshots/2022.5.0-my-new-feature.png
Architectural decision records (ADR)
[doc]
?CHANGELOG.adoc
?Dependencies
CHANGELOG.adoc
?CHANGELOG.adoc
?Frontend
This section is not relevant if your contribution does not come with changes to the frontend.
General purpose
Typing
We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).
useMutation<DATA_TYPE, VARIABLE_TYPE>(…)
useQuery<DATA_TYPE, VARIABLE_TYPE>(…)
useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)
useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)
useState<STATE_TYPE>(…)
?.
(if the GraphQL API specifies that a field cannot benull
, do not treat it has potentiallynull
for example)let diagram: Diagram | null = null;
)Backend
This section is not relevant if your contribution does not come with changes to the backend.
General purpose
Architecture
Review
How to test this PR?
Please describe here the various use cases to test this pull request