Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3215] Fix deletion tool on a diagram element from the VSCode extension #3224

Merged
merged 1 commit into from
Mar 13, 2024
Merged

[3215] Fix deletion tool on a diagram element from the VSCode extension #3224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ The implemented fix does not allow to evaluate an AQL expression, but only to re
- https://github.com/eclipse-sirius/sirius-web/issues/3185[#3185] [diagram] Fix an issue where child nodes were used in helper lines computation of container.
- https://github.com/eclipse-sirius/sirius-web/issues/3149[#3149] [diagram] Fix an issue where newly created border nodes could overlap existing one
- https://github.com/eclipse-sirius/sirius-web/issues/3217[#3217] [diagram] Prevent helper lines to be displayed on moving a pinned node
- https://github.com/eclipse-sirius/sirius-web/issues/3215[#3215] [vscode] Fix an issue where it was impossible to delete elements on a diagram from the VSCode extension.

=== New Features

Expand Down
16 changes: 11 additions & 5 deletions vscode-extension/src/view/app/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@
* Obeo - initial API and implementation
*******************************************************************************/

import { Selection, SelectionContextProvider } from '@eclipse-sirius/sirius-components-core';
import {
ConfirmationDialogContextProvider,
Selection,
SelectionContextProvider,
} from '@eclipse-sirius/sirius-components-core';
import { DiagramRepresentation } from '@eclipse-sirius/sirius-components-diagrams';
import { DetailsView, FormRepresentation } from '@eclipse-sirius/sirius-components-forms';
import React, { useEffect, useState } from 'react';
Expand Down Expand Up @@ -128,10 +132,12 @@ export const App = ({
}
return (
<SelectionContextProvider initialSelection={selection}>
<div style={appStyle}>
<div style={headerStyle}></div>
{state.editingContextId && state.authenticate ? <div style={componentStyle}>{component}</div> : null}
</div>
<ConfirmationDialogContextProvider>
<div style={appStyle}>
<div style={headerStyle}></div>
{state.editingContextId && state.authenticate ? <div style={componentStyle}>{component}</div> : null}
</div>
</ConfirmationDialogContextProvider>
</SelectionContextProvider>
);
};
Loading