-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2608] Improve the layout of edge handles on the left and right side of nodes #2603
Conversation
b07da96
to
736d175
Compare
736d175
to
7d0ac8b
Compare
@@ -102,6 +102,34 @@ export const ConnectionHandles = ({ connectionHandles }: ConnectionHandlesProps) | |||
return !!handlesSelected.find((selectedHandle) => selectedHandle === connectionHandle.id); | |||
}; | |||
|
|||
const rightSideVirtualHandleId = `handle--source--${nodeId}--${ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const rightSideVirtualHandleId = handle--source--${nodeId}--${ connectionHandles.filter((connectionHandle) => connectionHandle.type === 'source').length + 1 }
;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for the left one with target
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the second commit. It's not essential to the fix and causes unexpected problems.
The warning |
858515c
to
7d0ac8b
Compare
… nodes Make sure the "virtual" handles added after the real ones are not considered by the flexbox on the container. Bug: #2608 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
7d0ac8b
to
eff883c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be merged after a successful build
Signed-off-by: Pierre-Charles David pierre-charles.david@obeo.fr
Pull request template
General purpose
What is the main goal of this pull request?
Project management
priority:
andpr:
labels been added to the pull request? (In case of doubt, start with the labelspriority: low
andpr: to review later
)area:
,difficulty:
,type:
)CHANGELOG.adoc
been updated to reference the relevant issues?CHANGELOG.adoc
? (Including changes in the GraphQL API)CHANGELOG.adoc
? For example indoc/screenshots/2022.5.0-my-new-feature.png
Architectural decision records (ADR)
[doc]
?CHANGELOG.adoc
?Dependencies
CHANGELOG.adoc
?CHANGELOG.adoc
?Frontend
This section is not relevant if your contribution does not come with changes to the frontend.
General purpose
Typing
We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).
useMutation<DATA_TYPE, VARIABLE_TYPE>(…)
useQuery<DATA_TYPE, VARIABLE_TYPE>(…)
useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)
useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)
useState<STATE_TYPE>(…)
?.
(if the GraphQL API specifies that a field cannot benull
, do not treat it has potentiallynull
for example)let diagram: Diagram | null = null;
)Backend
This section is not relevant if your contribution does not come with changes to the backend.
General purpose
Architecture
Review
How to test this PR?
Please describe here the various use cases to test this pull request