[2456, 2466, 2469, 2470] Fixes on reference widget #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frouene
requested review from
pcdavid,
sbegaudeau and
AxelRICHARD
as code owners
This was
linked to
issues
Oct 18, 2023
frouene
force-pushed
the
fro/fix/widget_ref_issues
branch
from
6ebff75
to
a02c97b
Compare
pcdavid
requested changes
Oct 23, 2023
| cy.getByTestId('selected').findByTestId('Entity2').should('exist'); | ||
| }); | ||
|
|
||
| it.only('check widget reference filter ancestor only for containment reference', () => { |
| INVALID_INPUT = Invalid input type, "{0}" has been received while "{1}" was expected | ||
| UNEXPECTED_ERROR = An unexpected error has occurred, please contact the server administrator | ||
| INVALID_NUMBER = The new value "{0}" is not a valid number | ||
| UPPER_BOUNDARY_REACHED = Unable to create a new instance of "{0}" in feature "{1}" because it has reach its upper-bound cardinality." |
There was a problem hiding this comment.
The final " is not neeed; it shows as part of the message.
| @@ -39,12 +39,17 @@ public String unexpectedError() { | |||
|
|
|||
| @Override | |||
| public String invalidInput(String expectedInputTypeName, String receivedInputTypeName) { | |||
| return this.messageSourceAccessor.getMessage("INVALID_INPUT", new Object[] { expectedInputTypeName, receivedInputTypeName }); | |||
| return this.messageSourceAccessor.getMessage("INVALID_INPUT", new Object[]{expectedInputTypeName, receivedInputTypeName}); | |||
There was a problem hiding this comment.
The Eclipse formatting profile keeps the spaces between [, {, etc.
There was a problem hiding this comment.
Done,
I've changed my format settings
frouene
force-pushed
the
fro/fix/widget_ref_issues
branch
3 times, most recently
from
a848385
to
52a14ca
Compare
pcdavid
approved these changes
Oct 23, 2023
|
I'll merge once the build is green. |
…e from the reference widget Bug: #2470 Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
…et to a filtered item in the explorer Bug: #2469 Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
… reference widget Bug: #2466 Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
…o a mono reference no empty Bug: #2456 Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
…he option list in a reference widget modal transfert Bug: #2487 Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
pcdavid
force-pushed
the
fro/fix/widget_ref_issues
branch
from
52a14ca
to
41a9549
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
General purpose
What is the main goal of this pull request?
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,difficulty:,type:)CHANGELOG.adocbeen updated to reference the relevant issues?CHANGELOG.adoc? (Including changes in the GraphQL API)CHANGELOG.adoc? For example indoc/screenshots/2022.5.0-my-new-feature.pngArchitectural decision records (ADR)
[doc]?CHANGELOG.adoc?Dependencies
CHANGELOG.adoc?CHANGELOG.adoc?Frontend
This section is not relevant if your contribution does not come with changes to the frontend.
General purpose
Typing
We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).
useMutation<DATA_TYPE, VARIABLE_TYPE>(…)useQuery<DATA_TYPE, VARIABLE_TYPE>(…)useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)useState<STATE_TYPE>(…)?.(if the GraphQL API specifies that a field cannot benull, do not treat it has potentiallynullfor example)let diagram: Diagram | null = null;)Backend
This section is not relevant if your contribution does not come with changes to the backend.
General purpose
Architecture
Review
How to test this PR?
Please describe here the various use cases to test this pull request