Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2080] Add an inital label value when editing tree items label #2081

Merged
merged 1 commit into from
Jul 3, 2023
Merged

[2080] Add an inital label value when editing tree items label #2081

merged 1 commit into from
Jul 3, 2023

Conversation

mcharfadi
Copy link
Contributor

Bug: #2080

  • EditingContextRepresentationDataFetcher will filter on IRepresentation unstead of ISemanticRepresentation to be able to support TreeDescription. As such targetObjectId is removed from RepresentationMetadata.
  • The GraphQl input TreeEventInput now have an attribute treeId that start with "explorer://" when it's the explorer.
  • A React component TreeItemDirectEditInput and the interface IInitialDirectEditTreeItemLabelProvider on the back-end are created.

@mcharfadi mcharfadi added this to the 2023.8.0 milestone Jun 19, 2023
@mcharfadi mcharfadi self-assigned this Jun 19, 2023
@mcharfadi mcharfadi force-pushed the mch/enh/tree-direct-edit branch 7 times, most recently from 1f4dd60 to 7ecf494 Compare June 19, 2023 11:55
@sbegaudeau sbegaudeau linked an issue Jun 20, 2023 that may be closed by this pull request
Add an inital label value when editing tree items label #2080
Closed
sbegaudeau
sbegaudeau requested changes Jun 20, 2023
View reviewed changes
integration-tests/cypress/e2e/project/edit/explorer.cy.js Outdated Show resolved Hide resolved
integration-tests/cypress/e2e/project/edit/document-context-menu.cy.js Outdated Show resolved Hide resolved
CHANGELOG.adoc Outdated Show resolved Hide resolved
...pse/sirius/components/collaborative/editingcontext/EditingContextEventProcessorRegistry.java Outdated Show resolved Hide resolved
.../sirius/web/graphql/datafetchers/editingcontext/EditingContextRepresentationDataFetcher.java Outdated Show resolved Hide resolved
packages/trees/frontend/sirius-components-trees/src/treeitems/TreeItemDirectEditInput.tsx Outdated Show resolved Hide resolved
packages/trees/frontend/sirius-components-trees/src/treeitems/TreeItemDirectEditInput.tsx Outdated Show resolved Hide resolved
packages/trees/frontend/sirius-components-trees/src/treeitems/TreeItemDirectEditInput.tsx Outdated Show resolved Hide resolved
packages/trees/frontend/sirius-components-trees/src/treeitems/TreeItemDirectEditInput.types.ts Outdated Show resolved Hide resolved
packages/trees/frontend/sirius-components-trees/src/views/ExplorerView.tsx Show resolved Hide resolved
@mcharfadi mcharfadi changed the title [2080] Add direct edit support on trees elements [2080] Add an inital label value when editing tree items label Jun 20, 2023
@mcharfadi mcharfadi force-pushed the mch/enh/tree-direct-edit branch 6 times, most recently from f563a18 to e1c8853 Compare June 21, 2023 12:21
@sbegaudeau sbegaudeau force-pushed the mch/enh/tree-direct-edit branch 2 times, most recently from e2c75a0 to 0d6ff9b Compare July 3, 2023 08:45
@mcharfadi @sbegaudeau
[2080] Add an inital label value when editing tree items label
e5cda95 
Bug: #2080
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
sbegaudeau
sbegaudeau approved these changes Jul 3, 2023
View reviewed changes
...org/eclipse/sirius/web/services/explorer/ExplorerInitialDirectEditTreeItemLabelProvider.java Outdated

@Override
public IPayload handle(IEditingContext editingContext, Tree tree, InitialDirectEditElementLabelInput input) {
return new InitialDirectEditElementLabelSuccessPayload(input.id(), "");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to return here the current label of the selected tree item

@sbegaudeau sbegaudeau merged commit 4d9c791 into master Jul 3, 2023
3 checks passed
@pcdavid pcdavid deleted the mch/enh/tree-direct-edit branch July 3, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcdavid pcdavid pcdavid approved these changes

@sbegaudeau sbegaudeau sbegaudeau approved these changes

Assignees

@mcharfadi mcharfadi

Labels
pr: to review later priority: low
Projects
None yet
Milestone
2023.8.0
Development

Successfully merging this pull request may close these issues.

Add an inital label value when editing tree items label
3 participants
@mcharfadi @pcdavid @sbegaudeau