-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2004] Add an optional icon to select widget options #2005
Merged
AxelRICHARD
merged 1 commit into
eclipse-sirius:master
from
mcharfadi:mch/enh/icons-select-description
Jun 21, 2023
Merged
[2004] Add an optional icon to select widget options #2005
AxelRICHARD
merged 1 commit into
eclipse-sirius:master
from
mcharfadi:mch/enh/icons-select-description
Jun 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcharfadi
force-pushed
the
mch/enh/icons-select-description
branch
4 times, most recently
from
May 31, 2023 10:58
2cebc5a
to
f0dbacc
Compare
mcharfadi
requested review from
pcdavid,
AxelRICHARD and
sbegaudeau
as code owners
May 31, 2023 10:58
mcharfadi
force-pushed
the
mch/enh/icons-select-description
branch
from
May 31, 2023 12:28
f0dbacc
to
9365da8
Compare
1 task
mcharfadi
force-pushed
the
mch/enh/icons-select-description
branch
7 times, most recently
from
June 1, 2023 08:06
3bbca94
to
9eea702
Compare
mcharfadi
changed the title
[2004] Add icons label option to select widget
[2004] Add an optional icon to select widget options
Jun 1, 2023
mcharfadi
force-pushed
the
mch/enh/icons-select-description
branch
2 times, most recently
from
June 1, 2023 08:44
3162659
to
f48373b
Compare
AxelRICHARD
requested changes
Jun 1, 2023
...s-components-emf/src/main/java/org/eclipse/sirius/components/emf/services/ObjectService.java
Outdated
Show resolved
Hide resolved
.../forms/backend/sirius-components-collaborative-forms/src/main/resources/schema/form.graphqls
Outdated
Show resolved
Hide resolved
.../forms/backend/sirius-components-collaborative-forms/src/main/resources/schema/form.graphqls
Outdated
Show resolved
Hide resolved
.../forms/backend/sirius-components-collaborative-forms/src/main/resources/schema/form.graphqls
Outdated
Show resolved
Hide resolved
...ents-forms/src/main/java/org/eclipse/sirius/components/forms/components/SelectComponent.java
Outdated
Show resolved
Hide resolved
...ms/src/main/java/org/eclipse/sirius/components/forms/description/MultiSelectDescription.java
Outdated
Show resolved
Hide resolved
...ms/src/main/java/org/eclipse/sirius/components/forms/description/MultiSelectDescription.java
Outdated
Show resolved
Hide resolved
...s-forms/src/main/java/org/eclipse/sirius/components/forms/description/SelectDescription.java
Outdated
Show resolved
Hide resolved
...s-forms/src/main/java/org/eclipse/sirius/components/forms/description/SelectDescription.java
Outdated
Show resolved
Hide resolved
mcharfadi
force-pushed
the
mch/enh/icons-select-description
branch
2 times, most recently
from
June 1, 2023 13:18
e18487c
to
6e366d3
Compare
AxelRICHARD
requested changes
Jun 1, 2023
mcharfadi
force-pushed
the
mch/enh/icons-select-description
branch
from
June 1, 2023 13:40
6e366d3
to
26f9cf3
Compare
mcharfadi
force-pushed
the
mch/enh/icons-select-description
branch
2 times, most recently
from
June 9, 2023 12:13
0a02fe4
to
73ab740
Compare
AxelRICHARD
requested changes
Jun 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also rebase on master (which is now on 2023.6.1) please?
...s-forms/src/main/java/org/eclipse/sirius/components/forms/description/SelectDescription.java
Outdated
Show resolved
Hide resolved
...ain/java/org/eclipse/sirius/components/view/emf/form/ViewFormDescriptionConverterSwitch.java
Outdated
Show resolved
Hide resolved
...ain/java/org/eclipse/sirius/components/view/emf/form/ViewFormDescriptionConverterSwitch.java
Outdated
Show resolved
Hide resolved
mcharfadi
force-pushed
the
mch/enh/icons-select-description
branch
2 times, most recently
from
June 21, 2023 14:48
8eef014
to
3bb245c
Compare
Bug: eclipse-sirius#2004 Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
mcharfadi
force-pushed
the
mch/enh/icons-select-description
branch
from
June 21, 2023 14:55
3bb245c
to
60d6796
Compare
AxelRICHARD
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: #2004
Pull request template
General purpose
What is the main goal of this pull request?
Project management
priority:
andpr:
labels been added to the pull request? (In case of doubt, start with the labelspriority: low
andpr: to review later
)area:
,difficulty:
,type:
)CHANGELOG.adoc
been updated to reference the relevant issues?CHANGELOG.adoc
? (Including changes in the GraphQL API)CHANGELOG.adoc
? For example indoc/screenshots/2022.5.0-my-new-feature.png
Architectural decision records (ADR)
[doc]
?CHANGELOG.adoc
?Dependencies
CHANGELOG.adoc
?CHANGELOG.adoc
?Frontend
This section is not relevant if your contribution does not come with changes to the frontend.
General purpose
Typing
We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).
useMutation<DATA_TYPE, VARIABLE_TYPE>(…)
useQuery<DATA_TYPE, VARIABLE_TYPE>(…)
useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)
useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)
useState<STATE_TYPE>(…)
?.
(if the GraphQL API specifies that a field cannot benull
, do not treat it has potentiallynull
for example)let diagram: Diagram | null = null;
)Backend
This section is not relevant if your contribution does not come with changes to the backend.
General purpose
Architecture
Review
How to test this PR?
Please describe here the various use cases to test this pull request