Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2004] Add an optional icon to select widget options #2005

Merged

Conversation

mcharfadi
Copy link
Contributor

Bug: #2004

Pull request template

General purpose

What is the main goal of this pull request?

  • Bug fixes
  • New features
  • Documentation
  • Cleanup
  • Tests
  • Build / releng

Project management

  • Has the pull request been added to the relevant project and milestone? (Only if you know that your work is part of a specific iteration such as the current one)
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, difficulty:, type:)
  • Have the relevant issues been added to the same project and milestone as the pull request?
  • Has the CHANGELOG.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc? (Including changes in the GraphQL API)
  • In case of a change with a visual impact, are there any screenshots in the CHANGELOG.adoc? For example in doc/screenshots/2022.5.0-my-new-feature.png

Architectural decision records (ADR)

  • Does the title of the commit contributing the ADR start with [doc]?
  • Are the ADRs mentioned in the relevant section of the CHANGELOG.adoc?

Dependencies

  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • Are the new dependencies justified in the CHANGELOG.adoc?

Frontend

This section is not relevant if your contribution does not come with changes to the frontend.

General purpose

  • Is the code properly tested? (Plain old JavaScript tests for business code and tests based on React Testing Library for the components)

Typing

We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).

  • Variables have a proper type
  • Functions’ arguments have a proper type
  • Functions’ return type are specified
  • Hooks are properly typed:
    • useMutation<DATA_TYPE, VARIABLE_TYPE>(…)
    • useQuery<DATA_TYPE, VARIABLE_TYPE>(…)
    • useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)
    • useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)
    • useState<STATE_TYPE>(…)
  • All components have a proper typing for their props
  • No useless optional chaining with ?. (if the GraphQL API specifies that a field cannot be null, do not treat it has potentially null for example)
  • Nullable values have a proper type (for example let diagram: Diagram | null = null;)

Backend

This section is not relevant if your contribution does not come with changes to the backend.

General purpose

  • Are all the event handlers tested?
  • Are the event processor tested?
  • Is the business code (services) tested?
  • Are diagram layout changes tested?

Architecture

  • Are data structure classes properly separated from behavioral classes?
  • Are all the relevant fields final?
  • Is any data structure mutable? If so, please write a comment indicating why
  • Are behavioral classes either stateless or side effect free?

Review

How to test this PR?

Please describe here the various use cases to test this pull request

  • Has the Kiwi TCMS test suite been updated with tests for this contribution?

@mcharfadi mcharfadi force-pushed the mch/enh/icons-select-description branch 4 times, most recently from 2cebc5a to f0dbacc Compare May 31, 2023 10:58
@mcharfadi mcharfadi marked this pull request as ready for review May 31, 2023 10:58
@mcharfadi mcharfadi added this to the 2023.6.0 milestone May 31, 2023
@mcharfadi mcharfadi force-pushed the mch/enh/icons-select-description branch from f0dbacc to 9365da8 Compare May 31, 2023 12:28
@mcharfadi mcharfadi linked an issue May 31, 2023 that may be closed by this pull request
1 task
@mcharfadi mcharfadi force-pushed the mch/enh/icons-select-description branch 7 times, most recently from 3bbca94 to 9eea702 Compare June 1, 2023 08:06
@mcharfadi mcharfadi changed the title [2004] Add icons label option to select widget [2004] Add an optional icon to select widget options Jun 1, 2023
@mcharfadi mcharfadi force-pushed the mch/enh/icons-select-description branch 2 times, most recently from 3162659 to f48373b Compare June 1, 2023 08:44
@mcharfadi mcharfadi force-pushed the mch/enh/icons-select-description branch 2 times, most recently from e18487c to 6e366d3 Compare June 1, 2023 13:18
CHANGELOG.adoc Outdated Show resolved Hide resolved
CHANGELOG.adoc Outdated Show resolved Hide resolved
@mcharfadi mcharfadi force-pushed the mch/enh/icons-select-description branch from 6e366d3 to 26f9cf3 Compare June 1, 2023 13:40
@mcharfadi mcharfadi modified the milestones: 2023.6.0, 2023.8.0 Jun 7, 2023
Copy link
Contributor

@AxelRICHARD AxelRICHARD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also rebase on master (which is now on 2023.6.1) please?

@mcharfadi mcharfadi force-pushed the mch/enh/icons-select-description branch 2 times, most recently from 8eef014 to 3bb245c Compare June 21, 2023 14:48
Bug: eclipse-sirius#2004
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
@mcharfadi mcharfadi force-pushed the mch/enh/icons-select-description branch from 3bb245c to 60d6796 Compare June 21, 2023 14:55
@AxelRICHARD AxelRICHARD merged commit acf7e71 into eclipse-sirius:master Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an optional icon to select widget options
2 participants