Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1155] Use vertically aligned buttons to select the view to display #1157

Merged
merged 2 commits into from
Apr 20, 2022
Merged

[1155] Use vertically aligned buttons to select the view to display #1157

merged 2 commits into from
Apr 20, 2022

Conversation

pcdavid
Copy link
Member

@pcdavid pcdavid commented Apr 12, 2022

Bug: #1155
Signed-off-by: Pierre-Charles David pierre-charles.david@obeo.fr

Type of this PR

  • Bug fix
  • New feature or improvement
  • Documentation
  • Cleanup
  • Test
  • Build/Releng

Issue(s)

...

What does this PR do?

...

Screenshot/screencast of this PR

...

Potential side effects

...

How to test this PR?

  • Frontend Unit tests
  • Backend Unit tests
  • Cypress : please specify
  • Manual Test : please specify

Checklist

  • I have read CONTRIBUTING carefully.
  • I have signed the Contributor License Agreement.
  • All my commits are signed-off (-s) with my mail address of my Eclipse Account.
  • I have covered my changes by unit tests or integration tests or manual tests.
  • All tests pass.
  • I have updated the documentation accordingly
  • New React components are availables in storybook

@pcdavid pcdavid linked an issue Apr 12, 2022 that may be closed by this pull request
Replace accordions with a vertical bar of icons for the left and right panels #1155
Closed
@sbegaudeau sbegaudeau mentioned this pull request Apr 13, 2022
Closed
@sbegaudeau sbegaudeau added this to the 2022.5.0 milestone Apr 14, 2022
sbegaudeau
sbegaudeau requested changes Apr 14, 2022
View reviewed changes
frontend/src/workbench/Site.tsx Outdated Show resolved Hide resolved
frontend/src/workbench/Site.tsx Outdated Show resolved Hide resolved
frontend/src/workbench/Site.tsx Outdated Show resolved Hide resolved
frontend/src/workbench/Site.tsx Show resolved Hide resolved
@pcdavid pcdavid force-pushed the pcd/enh/vertical-bars branch 5 times, most recently from 74a9ffb to fb627ee Compare April 15, 2022 13:46
@pcdavid pcdavid requested a review from sbegaudeau April 19, 2022 07:12
@pcdavid @sbegaudeau
[1155] Use vertically aligned buttons to select the view to display
fd9762e 
Bug: #1155
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau
sbegaudeau requested changes Apr 20, 2022
View reviewed changes
Copy link
Member

@sbegaudeau sbegaudeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll push an update with the minor improvements for my comments.

frontend/src/theme.ts Outdated Show resolved Hide resolved
frontend/src/workbench/Site.tsx Outdated Show resolved Hide resolved
frontend/src/workbench/__tests__/Site.test.tsx Outdated Show resolved Hide resolved
frontend/src/workbench/__tests__/Site.test.tsx Outdated Show resolved Hide resolved
frontend/src/workbench/__tests__/Site.test.tsx Outdated Show resolved Hide resolved
@sbegaudeau
[releng] Bump version to 2022.3.6
b1e2eb3 
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
@sbegaudeau sbegaudeau merged commit ba62f1a into master Apr 20, 2022
@sbegaudeau sbegaudeau deleted the pcd/enh/vertical-bars branch April 20, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbegaudeau sbegaudeau sbegaudeau approved these changes

Assignees
No one assigned
Labels
pr: to review soon priority: high
Projects
None yet
Milestone
2022.5.0
Development

Successfully merging this pull request may close these issues.

Replace accordions with a vertical bar of icons for the left and right panels
2 participants
@pcdavid @sbegaudeau