[1068] Add support for displaying details on arbitrary element kinds #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sbegaudeau
commented
Feb 17, 2022
sbegaudeau
commented
- [1068] Add support for displaying details on arbitrary element kinds
- [test] Add additional tests to the collaborative form project
sbegaudeau
changed the title
sbegaudeau
force-pushed
the
sbe/enh/properties
branch
from
81edf7a
to
3ce9663
Compare
gcoutable
requested changes
Feb 18, 2022
...c/main/java/org/eclipse/sirius/components/collaborative/forms/FormDescriptionAggregator.java
Outdated
Show resolved
Hide resolved
...eclipse/sirius/components/collaborative/forms/handlers/EditMultiSelectEventHandlerTests.java
Outdated
Show resolved
Hide resolved
...eclipse/sirius/components/collaborative/forms/handlers/EditMultiSelectEventHandlerTests.java
Outdated
Show resolved
Hide resolved
.../org/eclipse/sirius/components/collaborative/forms/handlers/EditSelectEventHandlerTests.java
Outdated
Show resolved
Hide resolved
| formDescriptions.add(formDescription2); | ||
|
|
||
| FormDescriptionAggregator aggregator = new FormDescriptionAggregator(); | ||
| Optional<FormDescription> optional = aggregator.aggregate(formDescriptions, List.of(object), new IObjectService.NoOp()); |
There was a problem hiding this comment.
Is it relevant to test the behavior of the FormDescriptionAggregator when there are many objects?
There was a problem hiding this comment.
We would only test that we iterate properly on a for loop somewhere. I wanted to have at least one test here for now.
...onents-forms/src/main/java/org/eclipse/sirius/components/forms/components/FormComponent.java
Outdated
Show resolved
Hide resolved
Bug: #1068 Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau
force-pushed
the
sbe/enh/properties
branch
from
3ce9663
to
3830673
Compare
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.