[1063] Fix layout regression on tree items without children #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure there is always the same number of children element inside the tree item's main <div/> so the layout is the same whether or not the item has children. Bug: #1063 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid
added
area: frontend
pr: to review soon
type: bug
priority: high
and removed
type: bug
area: frontend
labels
gcoutable
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure there is always the same number of children element inside the tree item's main div so the layout is the same whether or not the item has children.
Bug: #1063
Signed-off-by: Pierre-Charles David pierre-charles.david@obeo.fr
Type of this PR
Issue(s)
#1063
What does this PR do?
This fixes a regression introduced in 48913d1 where tree items without children (and thus without the collaps/expand arrow) were no longer properly aligned with the others:
Screenshot/screencast of this PR