Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memoize diagram representation #3887

Closed
mcharfadi opened this issue Aug 27, 2024 · 0 comments · Fixed by #3888
Closed

Memoize diagram representation #3887

mcharfadi opened this issue Aug 27, 2024 · 0 comments · Fixed by #3888

Comments

@mcharfadi
Copy link
Contributor

When selection a node, the workbench is rerender and all the representations.

This is the result of profiling after changing the selection several times by clicking on nodes.
On a diagram with more than 1k nodes, the longest re renders are taking around 350ms
image

The same profiling but with DiagramRepresentation and ExplorerView memoized
The longest re re render (triggered by the re render of the Workbench) does not exceed 50ms.
image

@mcharfadi mcharfadi changed the title Memoize representations Memoize diagram representation Aug 27, 2024
mcharfadi added a commit that referenced this issue Aug 27, 2024
Bug: #3887
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
@mcharfadi mcharfadi self-assigned this Aug 27, 2024
@mcharfadi mcharfadi added this to the 2024.9.0 milestone Aug 27, 2024
@mcharfadi mcharfadi linked a pull request Aug 27, 2024 that will close this issue
39 tasks
mcharfadi added a commit that referenced this issue Aug 28, 2024
Bug: #3887
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
mcharfadi added a commit that referenced this issue Aug 28, 2024
Bug: #3887
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
sbegaudeau pushed a commit that referenced this issue Sep 12, 2024
Bug: #3887
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
sbegaudeau pushed a commit that referenced this issue Sep 12, 2024
Bug: #3887
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant