Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve extensibility of the NavigationBar #3563

Closed
wpiers opened this issue Jun 5, 2024 · 0 comments · Fixed by #3564
Closed

Improve extensibility of the NavigationBar #3563

wpiers opened this issue Jun 5, 2024 · 0 comments · Fixed by #3564
Labels
difficulty: medium package: sirius web type: enhancement
Milestone
2024.7.0

Comments

@wpiers
Copy link
Contributor

wpiers commented Jun 5, 2024

NavigationBar.tsx allows 2 extensions, the left icon and the right side actions.
The left icon contribution is encapsulated by an IconButton/Link/Tooltip which prevents advanced contributions.

The navigation bar should allow to extend its left and right sides.
wpiers added a commit to wpiers/sirius-components that referenced this issue Jun 5, 2024
@wpiers
[3563] Add NavigationBar extension points
cd018a5 
Bug: eclipse-sirius#3563
Signed-off-by: William Piers <william.piers@obeo.fr>
@wpiers wpiers mentioned this issue Jun 5, 2024
Merged
39 tasks
wpiers added a commit to wpiers/sirius-components that referenced this issue Jun 5, 2024
@wpiers
[3563] Add NavigationBar extension points
82d0d36 
Bug: eclipse-sirius#3563
Signed-off-by: William Piers <william.piers@obeo.fr>
wpiers added a commit to wpiers/sirius-components that referenced this issue Jun 6, 2024
@wpiers
[3563] Add NavigationBar extension points
bd6836b 
Bug: eclipse-sirius#3563
Signed-off-by: William Piers <william.piers@obeo.fr>
@sbegaudeau sbegaudeau added this to the 2024.7.0 milestone Jun 10, 2024
@sbegaudeau sbegaudeau linked a pull request Jun 10, 2024 that will close this issue
[3563] Improve NavigationBar extensibility #3564
Merged
39 tasks
sbegaudeau pushed a commit to wpiers/sirius-components that referenced this issue Jun 10, 2024
@wpiers @sbegaudeau
[3563] Add NavigationBar extension points
8c9faab 
Bug: eclipse-sirius#3563
Signed-off-by: William Piers <william.piers@obeo.fr>
sbegaudeau pushed a commit to wpiers/sirius-components that referenced this issue Jun 10, 2024
@wpiers @sbegaudeau
[3563] Add NavigationBar extension points
71a4e19 
Bug: eclipse-sirius#3563
Signed-off-by: William Piers <william.piers@obeo.fr>
sbegaudeau pushed a commit to wpiers/sirius-components that referenced this issue Jun 10, 2024
@wpiers @sbegaudeau
[3563] Add NavigationBar extension points
b3ea2d4 
Bug: eclipse-sirius#3563
Signed-off-by: William Piers <william.piers@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Jun 10, 2024
@wpiers @sbegaudeau
[3563] Add NavigationBar extension points
fb35c38 
Bug: #3563
Signed-off-by: William Piers <william.piers@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: medium package: sirius web type: enhancement
Projects
None yet
Milestone
2024.7.0
Development

Successfully merging a pull request may close this issue.

[3563] Improve NavigationBar extensibility wpiers/sirius-components
2 participants
@sbegaudeau @wpiers