Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent infinite loops in portals #2986

Closed
pcdavid opened this issue Jan 23, 2024 · 0 comments · Fixed by #2990
Closed

Prevent infinite loops in portals #2986

pcdavid opened this issue Jan 23, 2024 · 0 comments · Fixed by #2990
Assignees
@pcdavid
Labels
package: portal type: bug
Milestone
2024.1.0

Comments

@pcdavid
Copy link
Member

pcdavid commented Jan 23, 2024

Currently we prevent adding a portal into itself, but it is still possible to cause recursive loops indirectly, e.g. portal P1 contains portal P2 which contains portal P1.
This does not cause any issue on the backend, but opening such a portal on the front causes infinite rendering loops.
Creating such a structure should be prevented.
@pcdavid pcdavid added this to the 2024.1.0 milestone Jan 23, 2024
@pcdavid pcdavid self-assigned this Jan 23, 2024
pcdavid added a commit that referenced this issue Jan 23, 2024
@pcdavid
[2986] Prevent a portal from containing itself
e382b0a 
Bug: #2986
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid mentioned this issue Jan 23, 2024
Merged
@pcdavid pcdavid linked a pull request Jan 23, 2024 that will close this issue
[2986] Prevent a portal from containing itself #2990
Merged
frouene pushed a commit that referenced this issue Jan 23, 2024
@pcdavid @frouene
[2986] Prevent a portal from containing itself
bf6e7a4 
Bug: #2986
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcdavid pcdavid

Labels
package: portal type: bug
Projects
None yet
Milestone
2024.1.0
Development

Successfully merging a pull request may close this issue.

[2986] Prevent a portal from containing itself eclipse-sirius/sirius-web
1 participant
@pcdavid