Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a representation inside a portal does not place it where the user requested #2934

Closed
pcdavid opened this issue Jan 16, 2024 · 0 comments · Fixed by #2936
Closed

Adding a representation inside a portal does not place it where the user requested #2934

pcdavid opened this issue Jan 16, 2024 · 0 comments · Fixed by #2936
Assignees
@pcdavid
Labels
difficulty: medium package: portal type: bug
Milestone
2024.1.0

Comments

@pcdavid
Copy link
Member

pcdavid commented Jan 16, 2024 •
edited
Loading

When dropping a representation from the explorer onto a portal, a "phantom" element indicates where the user wants the new representation to appear. This is not correctly taken into account, and the newly added representation is currenly placed where the "phantom" element first entered into the portal's drop area.

Capture.video.du.2024-01-16.10-50-02.webm
@pcdavid pcdavid self-assigned this Jan 16, 2024
@pcdavid pcdavid added this to the 2024.1.0 milestone Jan 16, 2024
pcdavid added a commit that referenced this issue Jan 16, 2024
@pcdavid
[2934] Fix the initial position of representations added into portals
75cfbd2 
Bug: #2934
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid linked a pull request Jan 16, 2024 that will close this issue
[2934] Fix the initial position of representations added into portals #2936
Merged
39 tasks
pcdavid added a commit that referenced this issue Jan 16, 2024
@pcdavid
[2934] Fix the initial position of representations added into portals
14c406f 
Bug: #2934
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Jan 18, 2024
@pcdavid
[2934] Fix the initial position of representations added into portals
39fc785 
Bug: #2934
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Jan 19, 2024
@pcdavid
[2934] Fix the initial position of representations added into portals
6b2a509 
Bug: #2934
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Jan 19, 2024
@pcdavid
[2934] Fix the initial position of representations added into portals
7c794a5 
Bug: #2934
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Jan 19, 2024
@pcdavid
[2934] Fix the initial position of representations added into portals
8077ca0 
Bug: #2934
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcdavid pcdavid

Labels
difficulty: medium package: portal type: bug
Projects
None yet
Milestone
2024.1.0
Development

Successfully merging a pull request may close this issue.

[2934] Fix the initial position of representations added into portals eclipse-sirius/sirius-web
1 participant
@pcdavid