-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display the contents of a Portal in the Representations view #2890
Milestone
Comments
pcdavid
changed the title
Display the contents of a Portal in the _Representations_ view
Display the contents of a Portal in the Representations view
Jan 9, 2024
pcdavid
added a commit
that referenced
this issue
Jan 9, 2024
Bug: #2890 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid
added a commit
that referenced
this issue
Jan 10, 2024
Bug: #2890 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Merged
This was referenced Feb 2, 2024
pcdavid
added a commit
that referenced
this issue
Feb 7, 2024
Bug: #2890 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid
added a commit
that referenced
this issue
Feb 7, 2024
Rework the PortalEventProcessor and IPortalEventHandler so that: * handlers only compute the response (which makes them simpler); * the PortalEventProcessor handles the response by always updating/saving the new portal version (if there is one) before emiting notifications. This ensures that "downstream" representations like the Representations view see the correct, updated version of the Portal when the notification triggers their own refresh. This also centralizes the technical details about handling reactive streams correctly (instead of counting on each and every handler to e.g. always publish exactly one payload in all their code paths), and allows for "middleware" handlers like the example CountingHandler to be written once and apply to all handlers. Bug: #2890 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid
added a commit
that referenced
this issue
Feb 7, 2024
Rework the PortalEventProcessor and IPortalEventHandler so that: * handlers only compute the response (which makes them simpler); * the PortalEventProcessor handles the response by always updating/saving the new portal version (if there is one) before emiting notifications. This ensures that "downstream" representations like the Representations view see the correct, updated version of the Portal when the notification triggers their own refresh. This also centralizes the technical details about handling reactive streams correctly (instead of counting on each and every handler to e.g. always publish exactly one payload in all their code paths), and allows for "middleware" handlers like the example CountingHandler to be written once and apply to all handlers. Bug: #2890 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid
added a commit
that referenced
this issue
Feb 8, 2024
Bug: #2890 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid
added a commit
that referenced
this issue
Feb 8, 2024
Rework the PortalEventProcessor and IPortalEventHandler so that: * handlers only compute the response (which makes them simpler); * the PortalEventProcessor handles the response by always updating/saving the new portal version (if there is one) before emiting notifications. This ensures that "downstream" representations like the Representations view see the correct, updated version of the Portal when the notification triggers their own refresh. This also centralizes the technical details about handling reactive streams correctly (instead of counting on each and every handler to e.g. always publish exactly one payload in all their code paths), and allows for "middleware" handlers like the example CountingHandler to be written once and apply to all handlers. Bug: #2890 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid
added a commit
that referenced
this issue
Feb 9, 2024
Bug: #2890 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid
added a commit
that referenced
this issue
Feb 9, 2024
Rework the PortalEventProcessor and IPortalEventHandler so that: * handlers only compute the response (which makes them simpler); * the PortalEventProcessor handles the response by always updating/saving the new portal version (if there is one) before emiting notifications. This ensures that "downstream" representations like the Representations view see the correct, updated version of the Portal when the notification triggers their own refresh. This also centralizes the technical details about handling reactive streams correctly (instead of counting on each and every handler to e.g. always publish exactly one payload in all their code paths), and allows for "middleware" handlers like the example CountingHandler to be written once and apply to all handlers. Bug: #2890 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid
added a commit
that referenced
this issue
Feb 9, 2024
Bug: #2890 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid
added a commit
that referenced
this issue
Mar 19, 2024
Bug: #2890 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid
added a commit
that referenced
this issue
Mar 19, 2024
Bug: #2890 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid
added a commit
that referenced
this issue
Mar 20, 2024
Bug: #2890 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid
added a commit
that referenced
this issue
Mar 20, 2024
Bug: #2890 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid
added a commit
that referenced
this issue
Mar 20, 2024
Bug: #2890 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau
pushed a commit
that referenced
this issue
Mar 20, 2024
Bug: #2890 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau
pushed a commit
that referenced
this issue
Mar 20, 2024
Bug: #2890 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau
pushed a commit
that referenced
this issue
Mar 20, 2024
Bug: #2890 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau
pushed a commit
that referenced
this issue
Mar 20, 2024
Bug: #2890 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a Portal is selected, the Representations view should display a tree of all the representations embedded in the portal.
It should be a tree to also show the internals of any sub-portals.
Selecting a node in this tree should open the corresponding representation in "full mode".
Note that the Representations view on a semantic element shows a list of the representations attached to this element, where each item (representation) can be selected but also deleted. This is not possible when using a tree widget, where tree nodes do not support a delete action (or any other).
The text was updated successfully, but these errors were encountered: