Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EditingContextCrossReferenceAdapter delete too many objects #2601

Closed
4 tasks done
AxelRICHARD opened this issue Nov 20, 2023 · 0 comments · Fixed by #2602
Closed
4 tasks done

EditingContextCrossReferenceAdapter delete too many objects #2601

AxelRICHARD opened this issue Nov 20, 2023 · 0 comments · Fixed by #2602
Assignees
@AxelRICHARD
Labels
difficulty: medium package: emf type: bug
Milestone
2024.1.0

Comments

@AxelRICHARD
Copy link
Contributor

  • I have checked that this bug has not yet been reported by someone else
  • I have checked that this bug appears on Chrome
  • I have specified the version :
  • 2023.10.8
  • I have specified my environment :
  • All

Steps to reproduce

Try to move an object from a container to another (in the same document).
All references to this moved object are lost, because they are cleaned by EditingContextCrossReferenceAdapter.

Expected behavior

The references to a moved object are kept.

Actual behavior

The references to a moved object are lost.
@AxelRICHARD AxelRICHARD added this to the 2024.1.0 milestone Nov 20, 2023
@AxelRICHARD AxelRICHARD self-assigned this Nov 20, 2023
AxelRICHARD added a commit that referenced this issue Nov 20, 2023
@AxelRICHARD
[2601] Fix EditingContextCrossReferenceAdapter
2897ec9 
Bug: #2601
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
@AxelRICHARD AxelRICHARD mentioned this issue Nov 20, 2023
Merged
39 tasks
@AxelRICHARD AxelRICHARD linked a pull request Nov 20, 2023 that will close this issue
[2601] Prevent the deletion of references to moved objects #2602
Merged
39 tasks
AxelRICHARD added a commit that referenced this issue Nov 20, 2023
@AxelRICHARD
[2601] Fix EditingContextCrossReferenceAdapter
dcefbef 
Bug: #2601
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Nov 20, 2023
@AxelRICHARD
[2601] Prevent the deletion of references to moved objects
591caa5 
Bug: #2601
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Nov 20, 2023
@AxelRICHARD @sbegaudeau
[2601] Prevent the deletion of references to moved objects
8aed8c3 
Bug: #2601
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AxelRICHARD AxelRICHARD

Labels
difficulty: medium package: emf type: bug
Projects
None yet
Milestone
2024.1.0
Development

Successfully merging a pull request may close this issue.

[2601] Prevent the deletion of references to moved objects eclipse-sirius/sirius-web
1 participant
@AxelRICHARD