Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some success payload need to have Messages #2453

Closed
4 tasks done
jessymallet opened this issue Oct 6, 2023 · 0 comments · Fixed by #2506
Closed
4 tasks done

Some success payload need to have Messages #2453

jessymallet opened this issue Oct 6, 2023 · 0 comments · Fixed by #2506

Comments

@jessymallet
Copy link
Contributor

jessymallet commented Oct 6, 2023

When some tools are used, some message should be displayed to the user from the frontend.
For example, when a user try to Drag and drop an element in an other one, the user should be informed that the DnD is not possible or user could be informed of additional information.

To inform user, we would like to use org.eclipse.sirius.components.representations.Message. Unfortunately the DropOnDiagramSuccessPayload cannot encapsulate Message. Only failurePayload could display Message.
But org.eclipse.sirius.components.collaborative.diagrams.handlers.DropOnDiagramEventHandler return failure only if org.eclipse.sirius.components.view.emf.diagram.DiagramOperationInterpreter.executeTool(Tool, VariableManager) return a failure. The DnD AQL expression is evaluated with no error so there is no failure.

It would be interesting that DropOnDiagramSuccessPayload can encapsulate Message to display to the user. For example, on EditTextField request, we can see that the successPayLoad can encapsulate Message (see screenShot).

Several successPayload could be completed with Message :

  • DropOnDiagramSuccessPayload
  • DeleteFromDiagramSuccessPayload
  • SucessPayload from ReconnectEdgeEventHandler
  • EditLabelSuccessPayload
  • I have checked that this bug has not yet been reported by someone else
  • I have checked that this bug appears on Chrome
  • I have specified the version : 2023.10.1
  • I have specified my environment : Windows 11

Screenshots

serviceLogger

Steps to reproduce

  • try to add Message on Drag and Drop service

Expected behavior

  • Message is displayed to inform user

Actual behavior

  • No Message is displayed to inform user.
@frouene frouene self-assigned this Oct 10, 2023
@frouene frouene added this to the 2023.12.0 milestone Oct 10, 2023
frouene added a commit that referenced this issue Oct 25, 2023
Bug: #2453
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
@frouene frouene linked a pull request Oct 25, 2023 that will close this issue
39 tasks
@pcdavid pcdavid changed the title Some success payload need to haves Messages Some success payload need to have Messages Oct 28, 2023
pcdavid pushed a commit that referenced this issue Oct 31, 2023
Bug: #2453
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
pcdavid pushed a commit that referenced this issue Oct 31, 2023
Bug: #2453
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants