You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Actually, tool reconnection works fine in Sirius Web's sample application.
My understanding is that Sirius Components hard-codes in ViewReconnectionToolsExecutor.execute() the logic to locate the EdgeDescription. This hard-coded logic happens to work in the context of Sirius Web, but for other applications which manage their View instances differently, we should delegate to IViewRepresentationDescriptionSearchService.findViewEdgeDescriptionById(String) so that their own implementation of IViewRepresentationDescriptionSearchService, consistent with their View models integration, is used instead.
pcdavid
pushed a commit
to adaussy/sirius-components
that referenced
this issue
May 30, 2023
Delegate the search for the EdgeDescription to
IViewRepresentationDescriptionSearchService so that edge reconnection
can work for applications which customize this service.
Bug: eclipse-sirius#2003
Signed-off-by: Arthur Daussy <arthur.daussy@obeo.fr>
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid
changed the title
Tool reconnection doesn't work anymore
Tool reconnection doesn't work anymore for applications with a custom IViewRepresentationDescriptionSearchService
May 30, 2023
Delegate the search for the EdgeDescription to
IViewRepresentationDescriptionSearchService so that edge reconnection
can work for applications which customize this service.
Bug: eclipse-sirius#2003
Signed-off-by: Arthur Daussy <arthur.daussy@obeo.fr>
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Delegate the search for the EdgeDescription to
IViewRepresentationDescriptionSearchService so that edge reconnection
can work for applications which customize this service.
Bug: #2003
Signed-off-by: Arthur Daussy <arthur.daussy@obeo.fr>
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Screenshots
Actual behavior
The reconnection tool return an ErrorPayload with an empty message.
The text was updated successfully, but these errors were encountered: