Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for optional text completion on textfield widgets #1426

Closed
pcdavid opened this issue Oct 18, 2022 · 0 comments · Fixed by #1430
Closed

Add support for optional text completion on textfield widgets #1426

pcdavid opened this issue Oct 18, 2022 · 0 comments · Fixed by #1430

Comments

@pcdavid
Copy link
Member

pcdavid commented Oct 18, 2022

When editing text fields which are not "free form" but correspond to some constrained DSL, it would be nice to have support for completion proposals (computed on the backend). For example: AQL expressions or domain types in view definitions.

This should be optional, only enabled on Textfield widgets which explicitly provide a completion proposal provider. Ideally, there should be some visible affordance on such widgets to tell the end-user that completion is available on this widget.

The user-experience should be globally similar to what is customary in editors and IDEs like VS Code or Eclipse, but without all the bells and whistles:

  • triggered on some key combination (Ctrl+Space if possible), which sends a request to the backend;
  • upon receiving the possible completion proposals from the backend, open them in a list at the cursor's position;
  • if the user selects one of the proposals (using the mouse or, ideally, using the arrow keys), insert the proposal's text.
@pcdavid pcdavid added this to the 2023.1.0 milestone Oct 18, 2022
pcdavid added a commit that referenced this issue Oct 19, 2022
…dgets

Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid linked a pull request Oct 19, 2022 that will close this issue
39 tasks
pcdavid added a commit that referenced this issue Oct 26, 2022
…dgets

Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Oct 26, 2022
…dgets

Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Oct 27, 2022
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Oct 27, 2022
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Oct 27, 2022
…onent

Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Oct 27, 2022
…pletion

This will allow the frontend component to enable completion support only
for the text fields which actually support it.

Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Oct 27, 2022
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Oct 27, 2022
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Oct 27, 2022
… the View DSL

Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Oct 27, 2022
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid self-assigned this Nov 7, 2022
pcdavid added a commit that referenced this issue Nov 9, 2022
…onent

Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 9, 2022
…pletion

This will allow the frontend component to enable completion support only
for the text fields which actually support it.

Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 9, 2022
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 9, 2022
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 9, 2022
… the View DSL

Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 9, 2022
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 10, 2022
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 10, 2022
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 10, 2022
…onent

Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 10, 2022
…pletion

This will allow the frontend component to enable completion support only
for the text fields which actually support it.

Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 10, 2022
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Dec 7, 2022
… DSL

Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Dec 7, 2022
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Dec 7, 2022
It's more reliable than name-based heuristics.

Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Dec 7, 2022
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Dec 7, 2022
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Dec 7, 2022
Bug: Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Dec 12, 2022
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Dec 12, 2022
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Dec 12, 2022
…onent

Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Dec 12, 2022
…pletion

This will allow the frontend component to enable completion support only
for the text fields which actually support it.

Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Dec 12, 2022
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Dec 12, 2022
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Dec 12, 2022
… DSL

Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Dec 12, 2022
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Dec 12, 2022
It's more reliable than name-based heuristics.

Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Dec 12, 2022
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Dec 12, 2022
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Dec 12, 2022
Bug: Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Dec 12, 2022
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Dec 13, 2022
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Dec 13, 2022
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Jan 4, 2023
Most of the generated code is reformatted because the removal of
NON-NLS markers changes (in 4d42d96)
increased the line length available for actual code and the code was
not reformatted at the time.

Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Jan 4, 2023
Most of the generated code is reformatted because the removal of
NON-NLS markers changes (in 4d42d96)
increased the line length available for actual code and the code was
not reformatted at the time.

Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Jan 12, 2023
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Jan 12, 2023
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Jan 12, 2023
Bug: #1426
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant