New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for a tree widget in forms #1139

Closed

sbegaudeau opened this issue Apr 7, 2022 · 0 comments · Fixed by #1158

Assignees

Labels

difficulty: medium type: feature request

Milestone

Member

sbegaudeau commented Apr 7, 2022

We need to be able to display trees in form representations. For that, we will rely on the <TreeView />from MaterialUI since the use of the tree representation would be overkill for our need and it would require a large refactoring of the explorer.

We will need to write an ADR showing the necessary GraphQL API for the tree widget in order support the needs of the <TreeView /> along with the Java API of the tree widget description. We may need to discuss the ability (or not) to reuse the existing TreeDescription and Tree GraphQL type.

The text was updated successfully, but these errors were encountered:

sbegaudeau added type: feature request difficulty: medium area: backend labels

sbegaudeau added this to the 2022.5.0 milestone

pcdavid self-assigned this

pcdavid added a commit that referenced this issue


          [1139] Add ADR for the new tree widget in forms

8ab6b10

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid mentioned this issue

Add support for a tree widget in forms #1158

Merged

pcdavid added a commit that referenced this issue


          [1139] Add ADR for the new tree widget in forms

b98d936

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid linked a pull request

that will close this issue

Add support for a tree widget in forms #1158

Merged

pcdavid added a commit that referenced this issue


          [1139] Add ADR for the new tree widget in forms

64bea30

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid pinned this issue

sbegaudeau unpinned this issue

pcdavid pinned this issue

pcdavid unpinned this issue

pcdavid added a commit that referenced this issue


          [1139] Add ADR for the new tree widget in forms

1a31a05

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Add GraphQL Schema definitions

7852e02

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Add widget data structure implementation

3d6c2e6

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Add tree description

b5d2f46

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Implement TreeComponent rendering

033288c

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Implement TreePropertySection on the frontend

7d7c6d2

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Hard code a pseudo "semantic browser" in the default rules for…

eb09467

… testing

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Implement TreePropertySection on the frontend

7cbcbe3

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Hard code a pseudo "semantic browser" in the default rules for…

… testing

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Implement TreePropertySection on the frontend

c7f4279

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Hard code a pseudo "semantic browser" in the default rules for…

a9aeb7a

… testing

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Implement TreePropertySection on the frontend

fc97af3

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Hard code a pseudo "semantic browser" in the default rules for…

bd96862

… testing

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Add widget data structure implementation

d21aed5

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Update backend test helpers

182d86c

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Add ADR for the new tree widget in forms

53334f6

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Add GraphQL Schema definitions

6c7bac8

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Add widget data structure implementation

3a78756

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Add tree description

7a0291a

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Implement TreeComponent rendering

1c50d6d

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Implement TreePropertySection on the frontend

dba6a85

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Add frontend tests

d7112f7

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Complete backend test helpers to handle TreeWidget

cf521ee

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Complete backend test helpers to handle TreeWidget

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Add support for a new tree widget in forms

7c881b6

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid modified the milestones: 2022.5.0, 2022.7.0

pcdavid added a commit that referenced this issue


          [1139] Add support for a new tree widget in forms

8d7ab68

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Add support for a new tree widget in forms

e0a8bb3

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Add support for a new tree widget in forms

625b31a

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Add support for a new tree widget in forms

e4e9a3e

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Add support for a new tree widget in forms

b3bf3fc

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Add support for a new tree widget in forms

53cf696

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

pcdavid added a commit that referenced this issue


          [1139] Add support for a new tree widget in forms

04c46b7

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [1139] Add support for a new tree widget in forms

8b678e0

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [1139] Add support for a new tree widget in forms

d95cf87

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

sbegaudeau closed this as completed in #1158

sbegaudeau pushed a commit that referenced this issue


          [1139] Add support for a new tree widget in forms

42b96d4

Bug: #1139
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

lfasani added a commit that referenced this issue


          [1316][1139] Enhance the view model

6d33e8c

Now there are two separated concepts:
 * The node style description concept that tells how the node is
represented
 * The new concept of LayoutStrategyDescription that tells how the
children are layouted.

* Add new Styles
 - RectangularNodeStyleDescription
 - ImageNodeStyleDescription
 - SVGNodeStyleDescription
 - IconLabelNodeStyleDescription
* Add a "childrenLayoutStrategy" feature to NodeDescription. There are
two implementations
 - FreeFormLayoutStrategyDescription
 - ListLayoutStrategyDescription

Bug: #1316
Bug: #1139
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>

lfasani added a commit that referenced this issue


          [1316][1139] Enhance the view model

334ac0a

Now there are two separated concepts:
 * The node style description concept that tells how the node is
represented
 * The new concept of LayoutStrategyDescription that tells how the
children are layouted.

* Add new Styles
 - RectangularNodeStyleDescription
 - ImageNodeStyleDescription
 - IconLabelNodeStyleDescription
* Add a "childrenLayoutStrategy" feature to NodeDescription. There are
two implementations
 - FreeFormLayoutStrategyDescription
 - ListLayoutStrategyDescription

Bug: #1316
Bug: #1139
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>

pcdavid mentioned this issue

[1339] Add concepts of layout strategy #1327

Merged

39 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment