Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When opening a representation from its URL, it should be automatically visible and selected in the explorer #1070

Closed
pcdavid opened this issue Feb 15, 2022 · 0 comments · Fixed by #1079
Closed

When opening a representation from its URL, it should be automatically visible and selected in the explorer #1070

pcdavid opened this issue Feb 15, 2022 · 0 comments · Fixed by #1079
Assignees
@pcdavid
Labels
difficulty: medium type: enhancement
Milestone
2022.3.0

Comments

@pcdavid
Copy link
Member

pcdavid commented Feb 15, 2022

When opening a representation from its direct URL (by following a shared link, or simply opening it from the onboard area), the representation is open in the main area, but may not be visible in the explorer.
If it was already visible in the explorer, it appears selected, but for example when directly opening a link to a representation in a new browser tab, the explorer is initialized in its default state with only the root elements visible.

This results in a state which is different than when opening the representation by selecting it in the explorer, and does not show contextual information on the element to which the representation is attached.
@pcdavid pcdavid self-assigned this Feb 15, 2022
@pcdavid pcdavid pinned this issue Feb 15, 2022
@sbegaudeau sbegaudeau added this to the 2022.03.0 milestone Feb 15, 2022
pcdavid added a commit that referenced this issue Feb 21, 2022
@pcdavid
[1070] Reveal the currently selected representation in the explorer
b9aac8d 
- Switch to a flat tree format for the GraphQL message so that the
  frontend does not need to keep track of try to guess the depth of
  the tree (and remove the now obsolete maxDpeth).
- Ask the backend to reveal the currently selected elements by
  expanding their ancestors.
- Update TreeRenderer to convert elements to
  reveal (TreeEventInput.revealed) into ancestors to expand using the
  new TreeDescription.getAncestorsProvider().

Bug: #1070
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid mentioned this issue Feb 21, 2022
Merged
6 tasks
pcdavid added a commit that referenced this issue Feb 21, 2022
@pcdavid
[1070] Reveal the currently selected representation in the explorer
c13efd1 
- Switch to a flat tree format for the GraphQL message so that the
  frontend does not need to keep track of try to guess the depth of
  the tree (and remove the now obsolete maxDepth).
- Ask the backend to reveal the currently selected elements by
  expanding their ancestors.
- Update TreeRenderer to convert elements to
  reveal (TreeEventInput.revealed) into ancestors to expand using the
  new TreeDescription.getAncestorsProvider().

Bug: #1070
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Feb 22, 2022
@pcdavid
[1070] Reveal the currently selected representation in the explorer
8e9c4cd 
- Switch to a flat tree format for the GraphQL message so that the
  frontend does not need to keep track of try to guess the depth of
  the tree (and remove the now obsolete maxDepth).
- Ask the backend to reveal the currently selected elements by
  expanding their ancestors.
- Update TreeRenderer to convert elements to
  reveal (TreeEventInput.revealed) into ancestors to expand using the
  new TreeDescription.getAncestorsProvider().

Bug: #1070
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid linked a pull request Feb 22, 2022 that will close this issue
[1070] Reveal the currently selected representation in the explorer #1079
Merged
6 tasks
sbegaudeau added a commit that referenced this issue Feb 23, 2022
@sbegaudeau
[1070] Add an ADR to allow the explorer to reveal the current selection
8bab344 
Bug: #1070
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
pcdavid added a commit that referenced this issue Feb 28, 2022
@pcdavid
[1070] Reveal the currently selected element in the explorer
2c21768 
Bug: #1070
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Mar 1, 2022
@pcdavid
[1070] Ensure the selected item is visible
c897152 
Bug: #1070
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@sbegaudeau sbegaudeau unpinned this issue Mar 1, 2022
sbegaudeau added a commit that referenced this issue Mar 2, 2022
@sbegaudeau
[1070] Add an ADR to allow the explorer to reveal the current selection
b069c2a 
Bug: #1070
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Mar 2, 2022
@pcdavid @sbegaudeau
[1070] Reveal the currently selected element in the explorer
8bdc82f 
Bug: #1070
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Mar 2, 2022
@pcdavid @sbegaudeau
[1070] Ensure the selected item is visible
a1a23c6 
Bug: #1070
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau added a commit that referenced this issue Mar 2, 2022
@sbegaudeau
[1070] Add an ADR to allow the explorer to reveal the current selection
deacba4 
Bug: #1070
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Mar 2, 2022
@pcdavid @sbegaudeau
[1070] Reveal the currently selected element in the explorer
d5e07ab 
Bug: #1070
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Mar 2, 2022
@pcdavid @sbegaudeau
[1070] Ensure the selected item is visible
834975c 
Bug: #1070
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcdavid pcdavid

Labels
difficulty: medium type: enhancement
Projects
None yet
Milestone
2022.3.0
Development

Successfully merging a pull request may close this issue.

[1070] Reveal the currently selected representation in the explorer eclipse-sirius/sirius-web
2 participants
@pcdavid @sbegaudeau