Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to make specific changes before and after the layout #896

Closed
1 task done
AxelRICHARD opened this issue Dec 17, 2021 · 1 comment · Fixed by #898 or #910
Closed
1 task done

Allow to make specific changes before and after the layout #896

AxelRICHARD opened this issue Dec 17, 2021 · 1 comment · Fixed by #898 or #910
Assignees
@AxelRICHARD
Labels
difficulty: medium type: feature request
Milestone
2022.01.0

Comments

@AxelRICHARD
Copy link
Contributor

  • I have checked that this feature has not yet been suggested by someone else.

Expected behavior

As it is possible in SiriusDesktop (https://bugs.eclipse.org/bugs/show_bug.cgi?id=547598) SiriusComponents could allow to make
specific changes before and after the layout.

Potential side effects

Default implementation of beforeLayout and afterLayout won't do anything so no side effects.
@sbegaudeau sbegaudeau added this to the 2022.01.0 milestone Dec 17, 2021
AxelRICHARD added a commit to AxelRICHARD/sirius-components that referenced this issue Dec 17, 2021
@AxelRICHARD
[896] Allow to make specific changes before and after the layout
f39a717 
Bug: eclipse-sirius#896
Change-Id: Ia06fcedcef118aff35741f57e2847d9e1aa53862
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
@AxelRICHARD AxelRICHARD mentioned this issue Dec 17, 2021
Merged
2 tasks
AxelRICHARD added a commit to AxelRICHARD/sirius-components that referenced this issue Dec 20, 2021
@AxelRICHARD
[896] Allow to make specific changes before and after the layout
e718a93 
Bug: eclipse-sirius#896
Change-Id: Ia06fcedcef118aff35741f57e2847d9e1aa53862
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Dec 20, 2021
@AxelRICHARD @sbegaudeau
[896] Allow to make specific changes before and after the layout
9ec647d 
Bug: #896
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Dec 20, 2021
@AxelRICHARD @sbegaudeau
[896] Allow to make specific changes before and after the layout
bcc6c04 
Bug: #896
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
@sbegaudeau sbegaudeau linked a pull request Dec 20, 2021 that will close this issue
[896] Allow to make specific changes before and after the layout #898
Merged
2 tasks
@sbegaudeau
Copy link
Member

Merged in master

pcdavid added a commit that referenced this issue Dec 27, 2021
@pcdavid
[896] Add default implementation of the new methods to the interface
3712c8b 
This avoids breaking the API for existing clients.

Bug: #896
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid mentioned this issue Dec 27, 2021
Merged
17 tasks
@sbegaudeau sbegaudeau linked a pull request Jan 4, 2022 that will close this issue
[896] Add default implementation of the new methods to the interface #910
Merged
17 tasks
sbegaudeau pushed a commit that referenced this issue Jan 4, 2022
@pcdavid @sbegaudeau
[896] Add default implementation of the new methods to the interface
49636b3 
This avoids breaking the API for existing clients.

Bug: #896
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AxelRICHARD AxelRICHARD

Labels
difficulty: medium type: feature request
Projects
None yet
Milestone
2022.01.0
2 participants
@sbegaudeau @AxelRICHARD