Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagram accepts dropped elements even if in read only. #1269

Closed
4 tasks done
nvannr opened this issue Jun 14, 2022 · 0 comments · Fixed by #1270
Closed
4 tasks done

Diagram accepts dropped elements even if in read only. #1269

nvannr opened this issue Jun 14, 2022 · 0 comments · Fixed by #1270
Labels
difficulty: medium package: diagrams type: bug
Milestone
2022.9.0

Comments

@nvannr
Copy link
Contributor

nvannr commented Jun 14, 2022 •
edited
Loading

  • I have checked that this bug has not yet been reported by someone else
  • I have checked that this bug appears on Chrome
  • I have specified the version :
  • latest
  • I have specified my environment :
  • Windows

Screenshots

Steps to reproduce

  • Drop an element in a read only diagram

Expected behavior

Drops shouldn't be allowed in read only diagrams.

Actual behavior

Drops are allowed in read only diagrams.
nvannr added a commit to nvannr/sirius-components that referenced this issue Jun 14, 2022
@nvannr
[1269] Prevent dropping elements in a read only diagram
d24c074 
Bug: eclipse-sirius#1269
Signed-off-by: Nicolas Vannier <nicolas.vannier@obeo.fr>
@nvannr nvannr mentioned this issue Jun 14, 2022
Merged
39 tasks
nvannr added a commit to nvannr/sirius-components that referenced this issue Jun 14, 2022
@nvannr
[1269] Prevent dropping elements in a read only diagram
250097e 
Copyright update

Bug: eclipse-sirius#1269
Signed-off-by: Nicolas Vannier <nicolas.vannier@obeo.fr>
nvannr added a commit to nvannr/sirius-components that referenced this issue Jun 14, 2022
@nvannr
[1269] Prevent dropping elements in a read only diagram
6f4d580 
Copyright update

Bug: eclipse-sirius#1269
Signed-off-by: Nicolas Vannier <nicolas.vannier@obeo.fr>
nvannr added a commit to nvannr/sirius-components that referenced this issue Jun 14, 2022
@nvannr
[1269] Prevent dropping elements in a read only diagram
cf2087b 
Copyright update + fix

Bug: eclipse-sirius#1269
Signed-off-by: Nicolas Vannier <nicolas.vannier@obeo.fr>
nvannr added a commit to nvannr/sirius-components that referenced this issue Jun 15, 2022
@nvannr
[1269] Prevent dropping elements in a read only diagram
16fa5eb 
Copyright update + fix

Bug: eclipse-sirius#1269
Signed-off-by: Nicolas Vannier <nicolas.vannier@obeo.fr>
@sbegaudeau sbegaudeau added this to the 2022.7.0 milestone Jun 20, 2022
@sbegaudeau sbegaudeau linked a pull request Jun 20, 2022 that will close this issue
[1269] Prevent dropping elements in a read only diagram #1270
Merged
39 tasks
@sbegaudeau sbegaudeau modified the milestones: 2022.7.0, 2022.9.0 Jul 25, 2022
pcdavid pushed a commit to nvannr/sirius-components that referenced this issue Aug 31, 2022
@nvannr @pcdavid
[1269] Prevent dropping elements in a read only diagram
959554d 
Bug: eclipse-sirius#1269
Signed-off-by: Nicolas Vannier <nicolas.vannier@obeo.fr>
sbegaudeau pushed a commit to nvannr/sirius-components that referenced this issue Sep 1, 2022
@nvannr @sbegaudeau
[1269] Prevent dropping elements in a read only diagram
4cb5d64 
Bug: eclipse-sirius#1269
Signed-off-by: Nicolas Vannier <nicolas.vannier@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Sep 1, 2022
@nvannr @sbegaudeau
[1269] Prevent dropping elements in a read only diagram
06f53b1 
Bug: #1269
Signed-off-by: Nicolas Vannier <nicolas.vannier@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: medium package: diagrams type: bug
Projects
None yet
Milestone
2022.9.0
Development

Successfully merging a pull request may close this issue.

[1269] Prevent dropping elements in a read only diagram nvannr/sirius-components
2 participants
@sbegaudeau @nvannr