Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for displaying details on arbitrary element kinds #1068

Closed
pcdavid opened this issue Feb 15, 2022 · 0 comments · Fixed by #1076
Closed

Add support for displaying details on arbitrary element kinds #1068

pcdavid opened this issue Feb 15, 2022 · 0 comments · Fixed by #1076
Assignees
Milestone

Comments

@pcdavid
Copy link
Member

pcdavid commented Feb 15, 2022

Currently the "Details" view only supports showing properties of semantic elements.
This assumption is hard-coded in the frontend in PropertiesWebSocketContainerMachine which has:

      isSelectionUnsupported: (_, event) => {
        const { selection } = event as SwitchSelectionEvent;
        return !selection || !selection.kind.startsWith('siriusComponents://semantic');
      }

There is no reason for the frontend to care about the kind of element selected and restrict which are supported.
It should be up to the backend to decide if it has details to show for a particular selection (including a multiple selection).
For example it could make sense to display some properties/metadata on representations, or more generally on custom kinds of items specific to a particular application.

@pcdavid pcdavid added this to the 2022.03.0 milestone Feb 15, 2022
@pcdavid pcdavid self-assigned this Feb 15, 2022
@pcdavid pcdavid changed the title Add support for displaying details on arbitrary element kinds (incl. multiple elements) Add support for displaying details on arbitrary element kinds Feb 15, 2022
@pcdavid pcdavid assigned sbegaudeau and unassigned pcdavid Feb 15, 2022
sbegaudeau added a commit that referenced this issue Feb 17, 2022
Bug: #1068
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Feb 17, 2022
Bug: #1068
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Feb 18, 2022
Bug: #1068
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
gcoutable pushed a commit that referenced this issue Feb 21, 2022
Bug: #1068
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants