adds initial components and deployment and architecture diagram #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriksven
requested review from
sophokles73
and removed request for
sophokles73
|
@AnotherDaniel your feedback here is highly appreciated as well |
sophokles73
requested changes
Oct 18, 2024
|
|
||
| <img src=./img/overview.drawio.png> | ||
|
|
||
| In order to apply, the requested changes we need a so-called provider to communicate the requested changes from the Kuksa databroker to the underlying hardware. In many current vehicles this might be done over a CAN-bus. Since this blueprint focuses more on future vehicle generations and is intended as a technology showcase, we use Eclipse Zenoh instead. |
There was a problem hiding this comment.
Suggested change
| In order to apply, the requested changes we need a so-called provider to communicate the requested changes from the Kuksa databroker to the underlying hardware. In many current vehicles this might be done over a CAN-bus. Since this blueprint focuses more on future vehicle generations and is intended as a technology showcase, we use Eclipse Zenoh instead. | |
| In order to apply the requested changes, we need a so-called Kuksa _Provider_ to communicate the requested changes from the Kuksa Databroker to the underlying hardware. In many current vehicles this might be done over a CAN-bus. Since this blueprint focuses more on future vehicle generations and is intended as a technology showcase, we use Eclipse Zenoh instead. |
| <img src=./img/overview.drawio.png> | ||
|
|
||
| In order to apply, the requested changes we need a so-called provider to communicate the requested changes from the Kuksa databroker to the underlying hardware. In many current vehicles this might be done over a CAN-bus. Since this blueprint focuses more on future vehicle generations and is intended as a technology showcase, we use Eclipse Zenoh instead. | ||
| We use the Eclipse Kuksa Zenoh Provider which forwards messages between the gRPC-API of the Eclipse KUKSA Databroker and topics in the Zenoh network concerning the relevant and configurable VSS signals. |
There was a problem hiding this comment.
Suggested change
| We use the Eclipse Kuksa Zenoh Provider which forwards messages between the gRPC-API of the Eclipse KUKSA Databroker and topics in the Zenoh network concerning the relevant and configurable VSS signals. | |
| We use the Eclipse Kuksa Zenoh Provider which forwards messages between the gRPC-API of the Eclipse Kuksa Databroker and topics in the Zenoh network concerning the relevant and configurable VSS signals. |
| We use the Eclipse Kuksa Zenoh Provider which forwards messages between the gRPC-API of the Eclipse KUKSA Databroker and topics in the Zenoh network concerning the relevant and configurable VSS signals. | ||
|
|
||
| Translating between the HTTP/2 based gRPC communication and Eclipse Zenoh makes it possible to connect embedded devices like an Arduino or ESP32 which can use the [PicoZenoh implementation](https://github.com/eclipse-zenoh/zenoh-pico). | ||
| If you do not have such hardware available, there is also the option to use a Zenoh client in software as "software horn". |
There was a problem hiding this comment.
Suggested change
| If you do not have such hardware available, there is also the option to use a Zenoh client in software as "software horn". | |
| If you do not have such hardware available, there is also the option to use the _software horn_. |
|
|
||
| ### Horn Service Implementation | ||
|
|
||
| The [horn service implementation](./components/horn-service-kuksa/) provides the interfaces defined in the [COVESA uService for Horn](https://github.com/COVESA/uservices/blob/main/src/main/proto/vehicle/body/horn/v1/horn_service.proto). |
There was a problem hiding this comment.
Suggested change
| The [horn service implementation](./components/horn-service-kuksa/) provides the interfaces defined in the [COVESA uService for Horn](https://github.com/COVESA/uservices/blob/main/src/main/proto/vehicle/body/horn/v1/horn_service.proto). | |
| The [horn service implementation](./components/horn-service-kuksa/) provides the interfaces defined in the [COVESA Horn uService](https://github.com/COVESA/uservices/blob/main/src/main/proto/vehicle/body/horn/v1/horn_service.proto). |
| ### Horn Service Implementation | ||
|
|
||
| The [horn service implementation](./components/horn-service-kuksa/) provides the interfaces defined in the [COVESA uService for Horn](https://github.com/COVESA/uservices/blob/main/src/main/proto/vehicle/body/horn/v1/horn_service.proto). | ||
| The implementation relies in the [COVESA VSS Signal `Vehicle.Body.Horn.IsActive`](https://github.com/COVESA/vehicle_signal_specification/blob/6024c4b29065b37c074649a1a65396b9d4de9b55/spec/Body/Body.vspec#L65) managed by the Eclipse KUKSA Databroker. |
There was a problem hiding this comment.
Suggested change
| The implementation relies in the [COVESA VSS Signal `Vehicle.Body.Horn.IsActive`](https://github.com/COVESA/vehicle_signal_specification/blob/6024c4b29065b37c074649a1a65396b9d4de9b55/spec/Body/Body.vspec#L65) managed by the Eclipse KUKSA Databroker. | |
| The implementation utilizes the [`Vehicle.Body.Horn.IsActive` VSS Signal](https://github.com/COVESA/vehicle_signal_specification/blob/6024c4b29065b37c074649a1a65396b9d4de9b55/spec/Body/Body.vspec#L65) managed by the Eclipse Kuksa Databroker. |
There was a problem hiding this comment.
I kept in COVESA to emphasize that the uService and VSS are coming from the same alliance
|
@eriksven are you going to push changes to the README as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial PR for the service-to-signal blueprint.
There are a number of know issue which should be fixed soon after merging this PR. I put this PR anyway to already start and facilitate the overall review of the code. The issues are: