Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation errors in platform with I20230509-1800 compiler #444

Closed
iloveeclipse opened this issue May 10, 2023 · 5 comments
Closed

Compilation errors in platform with I20230509-1800 compiler #444

iloveeclipse opened this issue May 10, 2023 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@iloveeclipse
Copy link
Member

With the ECJ fix for eclipse-jdt/eclipse.jdt.core@eeef662 I see lot of compilation errors like Redundant specification of type arguments all over in the SDK workspace.

The errors are valid (compiler simply missed to report them before and this is fixed now) so we should make sure we fix them.

The fixes are trivial and I plan to provide PR's for them.

@jarthana: FYI.

@iloveeclipse iloveeclipse added the bug Something isn't working label May 10, 2023
@iloveeclipse iloveeclipse added this to the 4.28 M3 milestone May 10, 2023
@iloveeclipse iloveeclipse self-assigned this May 10, 2023
iloveeclipse added a commit to iloveeclipse/eclipse.platform.debug that referenced this issue May 10, 2023
iloveeclipse added a commit to iloveeclipse/eclipse.platform.ua that referenced this issue May 10, 2023
iloveeclipse added a commit to iloveeclipse/eclipse.platform.ui that referenced this issue May 10, 2023
iloveeclipse added a commit to iloveeclipse/eclipse.platform that referenced this issue May 10, 2023
iloveeclipse added a commit to iloveeclipse/eclipse.jdt.debug that referenced this issue May 10, 2023
iloveeclipse added a commit to eclipse-platform/eclipse.platform.debug that referenced this issue May 10, 2023
iloveeclipse added a commit to eclipse-platform/eclipse.platform.ua that referenced this issue May 10, 2023
iloveeclipse added a commit to eclipse-jdt/eclipse.jdt.debug that referenced this issue May 10, 2023
iloveeclipse added a commit to eclipse-platform/eclipse.platform.ui that referenced this issue May 10, 2023
@iloveeclipse
Copy link
Member Author

I've fixed errors I saw in my workspace on Linux, there could be other in Windows/Mac specific bundles we have, so if anyone sees some remaining errors, please fix.

Note: ideally that should be done soon before we switch to the updated ECJ build in M3.

@merks
Copy link
Contributor

merks commented May 10, 2023

🥇 Thanks you for fixing all these issues so promptly! My SDK workspace is error free on Windows after pulling your changes.

@iloveeclipse
Copy link
Member Author

The reason is simple: I use latest nightly build on every work day & and I can't work on anything else if my workspace has errors.

@jarthana
Copy link

Thanks Andrey for taking care of this!

@iloveeclipse
Copy link
Member Author

Thanks Andrey for taking care of this!

You are welcome Jay as long as you continue taking care of JDT :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants