[StickyScrolling] Introduce enhancement point #2756
+603
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to implement editor/language specific sticky lines provider, a new extension point is introduced.
BeckerWdf
reviewed
Jan 24, 2025
| @@ -15,7 +15,8 @@ Export-Package: | |||
| org.eclipse.ui.internal.editors.text.codemining.annotation;x-internal:=true, | |||
| org.eclipse.ui.internal.texteditor;x-internal:=true, | |||
| org.eclipse.ui.internal.texteditor.stickyscroll;x-internal:=true, | |||
| org.eclipse.ui.texteditor | |||
| org.eclipse.ui.texteditor, | |||
| org.eclipse.ui.texteditor.stickyscroll;x-internal:=true | |||
There was a problem hiding this comment.
so we would remove the "x-internal:=true" part to make this "real" API once we are confident enough?
There was a problem hiding this comment.
Yes, that would be the idea. But I'm not sure if this is the right approach or if this is a good idea.
|
Can this share a lot of code with the folding range? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to implement editor/language specific sticky lines provider, a new extension point is introduced.
See issues:
The idea is that the package of the extension point is internal in the first place.
If both implementation works as expected, the API is most probably stable and we can change to package of the extension point to public usage.