Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove done() call on SubMonitor in Refactoring #2578

Conversation

vogella
Copy link
Contributor

@vogella vogella commented Dec 3, 2024

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Test Results

 1 821 files   1 821 suites   1h 31m 6s ⏱️
 7 719 tests  7 489 ✅ 228 💤 2 ❌
24 318 runs  23 567 ✅ 749 💤 2 ❌

For more details on these failures, see this check.

Results for commit f4a3c41.

♻️ This comment has been updated with latest results.

jukzi
jukzi previously requested changes Dec 4, 2024
Copy link
Contributor

@jukzi jukzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The caller Will not expect that the callee invokes done() on the monitor. The caller must either use an SubMonitor (or a similar implementation which does not require done() to be invoked), or it must take responsibility for calling done() on the monitor after the callee has finished.
Reads like this done() is valid

@vogella
Copy link
Contributor Author

vogella commented Dec 4, 2024

The caller Will not expect that the callee invokes done() on the monitor. The caller must either use an SubMonitor (or a similar implementation which does not require done() to be invoked), or it must take responsibility for calling done() on the monitor after the callee has finished. Reads like this done() is valid

See Changes in Eclipse 4.7

@vogella vogella dismissed jukzi’s stale review December 4, 2024 13:38

See 5.3 Changes in Eclipse 4.7

@laeubi laeubi force-pushed the submonitor-done-call-remove-in-refactoring-class branch from aaddfd6 to f4a3c41 Compare February 2, 2025 05:58
@vogella vogella closed this Feb 3, 2025
@vogella vogella deleted the submonitor-done-call-remove-in-refactoring-class branch February 3, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants