Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily use 2024-06 API-Tools for API checks in verification builds #2374

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

HannesWell
Copy link
Member

Revert to use previous release's API-Tools to hopefully unblock verification builds that are currently suffering from #2360 (comment).

If this doesn't help, the problem is probably not directly within PDE's API-Tools but in the integration with Tycho.

@HannesWell
Copy link
Member Author

Temporarily revert to use previous release's API-Tools to unblock
verification builds.
@HannesWell HannesWell changed the title Use 2024-06 API-Tools for API checks in verification builds Temporarily use 2024-06 API-Tools for API checks in verification builds Sep 22, 2024
@HannesWell
Copy link
Member Author

Ok, so with this applied and the api-checks profile enabled it still happens that the tycho-apitools:verify mojo hangs and I therefore assume eclipse-tycho/tycho#4105 has something to do with it.
But since I also saw false positive errors/warnings I assume that the underlying PDE Api-Tools als cause some troubles. Therefore I suspect that this could still fix some problems in verification builds. At least it worked to check a few plug-ins and also worked with tycho 4.0.8 and I didn't saw a change that should be incompatible to the old api-tools version.
So I hope that in the worst case, this simply does not help.

@HannesWell HannesWell merged commit 9e0e8dd into eclipse-platform:master Sep 22, 2024
3 of 4 checks passed
@HannesWell HannesWell deleted the api-check-with24-06 branch September 22, 2024 21:28
@laeubi
Copy link
Contributor

laeubi commented Sep 23, 2024

Ok, so with this applied and the api-checks profile enabled it still happens that the tycho-apitools:verify mojo hangs

Is there a way to reproduce the problem e.g. can one build a single project to see the hang or does it only happen randomly?

@HannesWell
Copy link
Member Author

Ok, so with this applied and the api-checks profile enabled it still happens that the tycho-apitools:verify mojo hangs

Is there a way to reproduce the problem e.g. can one build a single project to see the hang or does it only happen randomly?

I didn't see a systematic schema so I think it's random. But when I run the aggregator build it usually hangs after a few projects have been built.

@HannesWell
Copy link
Member Author

Btw. if we don't find another immediate remediation, couldn't we simply use only the apitools plug-in in version 4.0.8?

@iloveeclipse
Copy link
Member

Could it be, that jenkins builds are failing now because something is not in-sync with the pom config?
See https://ci.eclipse.org/platform/job/eclipse.platform.ui/job/PR-2288/4/console for recent build failure
for PR that was green before rebase: eclipse-platform/eclipse.platform.ui#2288

@HannesWell
Copy link
Member Author

Could it be, that jenkins builds are failing now because something is not in-sync with the pom config? See https://ci.eclipse.org/platform/job/eclipse.platform.ui/job/PR-2288/4/console for recent build failure for PR that was green before rebase: eclipse-platform/eclipse.platform.ui#2288

I cannot really say anything with certainty. I assume this didn't make it worse, but I cannot guarantee it.
But I have started another attempt for a work-around to unblock verification builds:

@iloveeclipse
Copy link
Member

Could it be, that jenkins builds are failing now because something is not in-sync with the pom config? See https://ci.eclipse.org/platform/job/eclipse.platform.ui/job/PR-2288/4/console for recent build failure for PR that was green before rebase: eclipse-platform/eclipse.platform.ui#2288

I cannot really say anything with certainty. I assume this didn't make it worse, but I cannot guarantee it. But I have started another attempt for a work-around to unblock verification builds:

The funny thing is that PR build failed 3 times with different issues (two times due API errors) and after that it succeeded without any change in the code. So I assume we have (had?) some infrastructure issues.

@HannesWell
Copy link
Member Author

The funny thing is that PR build failed 3 times with different issues (two times due API errors) and after that it succeeded without any change in the code. So I assume we have (had?) some infrastructure issues.

That's also possible, but as far as I can tell #2380 improved the situation for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants