Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Build with Tycho 2.7.4" #1114

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Conversation

eparovyshnaya
Copy link
Contributor

Reverts #1113

Passage 250 m1 fails on Jenkins

https://ci.eclipse.org/passage/job/passage-base/1424/console

[ERROR] Plugin org.eclipse.tycho.extras:tycho-pack200a-plugin:2.7.4 or one of its dependencies could not be resolved: org.eclipse.tycho.extras:tycho-pack200a-plugin:jar:2.7.4 was not found in https://repo.eclipse.org/content/repositories/tycho-snapshots/ during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of tycho-snapshots has elapsed or updates are forced

Let's try again later (for M2 probably), currently we have no resources for this.

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #1114 (6790408) into master (7599093) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1114      +/-   ##
============================================
- Coverage     33.21%   33.21%   -0.01%     
  Complexity      356      356              
============================================
  Files          1161     1161              
  Lines         25700    25700              
  Branches       1589     1589              
============================================
- Hits           8536     8535       -1     
- Misses        16659    16660       +1     
  Partials        505      505              
Impacted Files Coverage Δ
...rg/eclipse/passage/lic/bc/BcResidentSecretKey.java 91.30% <0.00%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7599093...6790408. Read the comment docs.

Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pack200 was deprecated as no more supported for modern Java versions and we need to remove it on M2. But for now let's revert the tycho upgrade

@eparovyshnaya eparovyshnaya merged commit 7232d34 into master Jul 13, 2022
@HannesWell
Copy link
Contributor

The removal of tycho-pack200a-plugin indeed happened unintentionally for Tycho 2.7.4.
As suggested in eclipse-tycho/tycho#903 (comment) I can recreated PR #1113 but set the pack200 plug-ins to version 2.7.3. You can then remove them as part of your work to remove pack200 entirely.

@ruspl-afed ruspl-afed deleted the revert-1113-tycho_2_7_4 branch August 21, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants