license - clarify licensing in line with Eclipse Paho standard #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users could previously access/change the ClientConfig held by `paho.Client`; this invited race conditions (`paho.Client` could use values from the config at any time and no locking mechanism was provided). To avoid this, the config is now private and examples etc have been updated. A getter for `ClientID` has been added (as this was needed in examples); I suspect additional getters may be of benefit (but will await feedback for that). This may break some users code (but that is probably a good thing)
Previously there was a LICENSE file (EPL-V2) and a DISTRIBUTION file (EDL-1); this was not completely clear (as pointed out in issue #223). This PR copies the license files from paho.mqtt.golang (which follow the standard set in the C library, with tweaks so pkg.go.dev will display the docs). The PR also introduces copyright headers in all Go files as required by the eclipse licensing documentation (https://www.eclipse.org/projects/tools/documentation.php?id=iot.paho).
Previously there was a LICENSE file (EPL-V2) and a DISTRIBUTION file (EDL-1); this was not completely clear (as pointed out in issue #223). This PR copies the license files from paho.mqtt.golang (which follow the standard set in the C library, with tweaks so pkg.go.dev will display the docs). The PR also introduces copyright headers in all Go files as required by the eclipse licensing documentation (https://www.eclipse.org/projects/tools/documentation.php?id=iot.paho).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was a LICENSE file (EPL-V2) and a DISTRIBUTION file (EDL-1); this was not
completely clear (as pointed out in issue #223).
This PR copies the license files from paho.mqtt.golang (which follow the standard set in the
C library, with tweaks so pkg.go.dev will display the docs).
The PR also introduces copyright headers in all Go files as required by the eclipse licensing
documentation (https://www.eclipse.org/projects/tools/documentation.php?id=iot.paho).
closes #223