Direct call fixes for JITServer on Power #7384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci] Signed-off-by: Dhruv Chopra <Dhruv.C.Chopra@ibm.com>
fjeremic
added
comp:jitserver
ymanton
requested changes
Oct 22, 2019
dchopra001
force-pushed
the
directCallFixes
branch
from
2adfa50 to
e577eaf
Compare
For recursive direct calls, we can generate a branch relative instruction back to startPC. So we don't need to generate relocation records for those scenarios. [skip ci] Signed-off-by: Dhruv Chopra <Dhruv.C.Chopra@ibm.com>
dchopra001
force-pushed
the
directCallFixes
branch
from
e577eaf to
c1f8a4e
Compare
ymanton
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add
TR_MethodCallAddressrelocation types here and JITServer checks for direct calls. Additionally, we don't generate a relocation record when a function is calling itself (because we can generate a PC relative instruction back to thestartPCinstead).