Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JITServer Compilation Fixes for Power #6990

Merged
merged 1 commit into from
Oct 25, 2019

Conversation

dchopra001
Copy link
Contributor

Signed-off-by: Dhruv Chopra Dhruv.C.Chopra@ibm.com

@dchopra001 dchopra001 mentioned this pull request Sep 5, 2019
17 tasks
@0xdaryl 0xdaryl added comp:build comp:jitserver Artifacts related to JIT-as-a-Service project labels Sep 10, 2019
@fjeremic fjeremic self-assigned this Sep 10, 2019
@fjeremic
Copy link
Contributor

Jenkins test sanity plinux,aix jdk8

@fjeremic
Copy link
Contributor

@dchopra001 please see compilation failures. Sounds like protobufs are missing on these machines.

@mpirvu
Copy link
Contributor

mpirvu commented Sep 17, 2019

#7099 is being worked on

@fjeremic fjeremic self-requested a review September 24, 2019 13:07
@fjeremic
Copy link
Contributor

fjeremic commented Oct 7, 2019

@dchopra001 let us know when this is ready for review. Otherwise if there is still work to be done please prefix the PR with a WIP: so committers know there is no action to take.

@dchopra001 dchopra001 changed the title JITServer Compilation Fixes for Power WIP: JITServer Compilation Fixes for Power Oct 7, 2019
@dchopra001
Copy link
Contributor Author

OOPS! Sorry I was using this branch as my dev branch. Didn't realize there was a PR open against it. I'll fix this.

@dchopra001 dchopra001 force-pushed the jitaasOnP branch 2 times, most recently from aebac2a to a73a310 Compare October 24, 2019 00:08
@dchopra001 dchopra001 changed the title WIP: JITServer Compilation Fixes for Power JITServer Compilation Fixes for Power Oct 24, 2019
[skip ci]
Signed-off-by: Dhruv Chopra <Dhruv.C.Chopra@ibm.com>
@dchopra001
Copy link
Contributor Author

@mpirvu @fjeremic This one is good for another round of reviews+merge.

Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as far as I understand makefiles

@fjeremic
Copy link
Contributor

Jenkins test compile all jdk8

@dchopra001
Copy link
Contributor Author

@fjeremic protobufs is still not available on the power machines, so the builds will still fail.

@fjeremic
Copy link
Contributor

@fjeremic protobufs is still not available on the power machines, so the builds will still fail.

Ok, so this is going into the jitaas branch so it won't affect master then.

@fjeremic fjeremic merged commit 5861262 into eclipse-openj9:jitaas Oct 25, 2019
@dchopra001 dchopra001 deleted the jitaasOnP branch July 13, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch:power comp:build comp:jitserver Artifacts related to JIT-as-a-Service project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants