-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JITServer Compilation Fixes for Power #6990
Conversation
Jenkins test sanity plinux,aix jdk8 |
@dchopra001 please see compilation failures. Sounds like protobufs are missing on these machines. |
#7099 is being worked on |
@dchopra001 let us know when this is ready for review. Otherwise if there is still work to be done please prefix the PR with a WIP: so committers know there is no action to take. |
OOPS! Sorry I was using this branch as my dev branch. Didn't realize there was a PR open against it. I'll fix this. |
aebac2a
to
a73a310
Compare
[skip ci] Signed-off-by: Dhruv Chopra <Dhruv.C.Chopra@ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as far as I understand makefiles
Jenkins test compile all jdk8 |
@fjeremic protobufs is still not available on the power machines, so the builds will still fail. |
Ok, so this is going into the jitaas branch so it won't affect master then. |
Signed-off-by: Dhruv Chopra Dhruv.C.Chopra@ibm.com